fix(drizzle): surface connection errors in beginTransaction instead of hanging forever#16220
Merged
fix(drizzle): surface connection errors in beginTransaction instead of hanging forever#16220
Conversation
AlessioGr
commented
Apr 9, 2026
| }) | ||
| } | ||
|
|
||
| it('should throw error when beginTransaction fails to connect', async () => { |
Member
Author
There was a problem hiding this comment.
Before this change, this test failed on postgres/sqlite through timing out
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
r1tsuu
reviewed
Apr 9, 2026
Member
r1tsuu
left a comment
r1tsuu
left a comment
There was a problem hiding this comment.
Some failing tests but I think it's expected, just need to suppress them
r1tsuu
approved these changes
Apr 10, 2026
Contributor
|
🚀 This is included in version v3.83.0 |
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
…f hanging forever (payloadcms#16220) When `beginTransaction` fails to establish a database connection (e.g. due to network issues or expired AWS IAM tokens), the function hangs forever instead of throwing an error. This happens because `drizzle.transaction()` rejects when the connection fails, but the old `.catch(() => { // swallow })` silently ate the error. Since the transaction callback never ran, `transactionReady()` was never called, leaving the outer `await` permanently suspended. Callers never receive an error and the operation never completes. The fix replaces the swallowed `.catch` with one that rejects the outer promise, so the existing `try/catch` block can log the real error and re-throw it to callers. ## What happened in practice In practice, this issue resulted in the job queue to randomly stop processing jobs, if a previous cron hangs during `beginTransaction`. The only way to get it to start processing jobs again was to restart the node process. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1213983836266037
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
beginTransactionfails to establish a database connection (e.g. due to network issues or expired AWS IAM tokens), the function hangs forever instead of throwing an error.This happens because
drizzle.transaction()rejects when the connection fails, but the old.catch(() => { // swallow })silently ate the error. Since the transaction callback never ran,transactionReady()was never called, leaving the outerawaitpermanently suspended. Callers never receive an error and the operation never completes.The fix replaces the swallowed
.catchwith one that rejects the outer promise, so the existingtry/catchblock can log the real error and re-throw it to callers.What happened in practice
In practice, this issue resulted in the job queue to randomly stop processing jobs, if a previous cron hangs during
beginTransaction. The only way to get it to start processing jobs again was to restart the node process.