fix(drizzle): error when using contains operator on hasMany select fields#15865
Merged
fix(drizzle): error when using contains operator on hasMany select fields#15865
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
PatrikKozak
requested changes
Mar 6, 2026
PatrikKozak
approved these changes
Mar 6, 2026
Contributor
|
🚀 This is included in version v3.79.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
containsoperator on hasManyselectfields in PostgreSQL. This was a regression introduced in #15671.The problem
Given a collection with a hasMany
selectfield:Payload stores this across two PostgreSQL tables. For a user created with
roles: ['admin', 'editor']:usersusers_rolesadmineditorThe
valuecolumn is a PostgreSQL enum type, not avarchar.When querying
{ roles: { contains: 'admin' } }, Payload generated:ILIKEdoes not work on PostgreSQL enum types.The fix
The LEFT JOIN already flattens the array into individual rows:
admineditorSo "contains admin" just means "has a row where value equals admin". The fix converts
containstoequalsfor hasManyselectfields, the same way it already works for hasManyrelationshipanduploadfields:Why hasMany
textfields are differentHasMany
textfields store values asvarchar, not as an enum.ILIKEworks fine onvarcharcolumns, so substring matching (contains: 'adm'matching'admin') is valid there. Whether it's desirable is a problem separate from this PR, being discussed internally here