fix(drizzle): correctly apply query limit on polymorphic joins#15652
Merged
JessRynkar merged 1 commit intomainfrom Mar 5, 2026
Merged
fix(drizzle): correctly apply query limit on polymorphic joins#15652JessRynkar merged 1 commit intomainfrom
JessRynkar merged 1 commit intomainfrom
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
048a184 to
af42b76
Compare
DanRibbens
previously requested changes
Feb 18, 2026
af42b76 to
803a497
Compare
|
We can confirm that this PR fixes our issue when we manually apply it to our instance. |
r1tsuu
approved these changes
Mar 5, 2026
Contributor
|
🚀 This is included in version v3.79.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue where querying folders with nested subfolders returned incorrect results when using SQL databases.
Why?
When resolving nested folder relationships, the generated polymorphic
UNIONquery appliedLIMITat the global level. This caused the limit to be enforced across the entire result set before rows were correlated back to their respective parent folders.As a result, some parents received incomplete or incorrect child data.
How?
The polymorphic join query has been restructured so that parent correlation occurs before applying the
LIMIT. This ensures:LIMITis enforced per parentTesting
folders > int