chore(db-postgres): enable TypeScript strict (#11560)

Author: GermanJablo

packages/db-postgres/src/connect.ts

@@ -1,5 +1,5 @@
 import type { DrizzleAdapter } from '@payloadcms/drizzle/types'
-import type { Connect, Payload } from 'payload'
+import type { Connect, Migration, Payload } from 'payload'
 
 import { pushDevSchema } from '@payloadcms/drizzle'
 import { drizzle } from 'drizzle-orm/node-postgres'
@@ -75,15 +75,16 @@ export const connect: Connect = async function connect(
         this.payload.logger.info('---- DROPPED TABLES ----')
       }
     }
-  } catch (err) {
+  } catch (error) {
+    const err = error instanceof Error ? error : new Error(String(error))
     if (err.message?.match(/database .* does not exist/i) && !this.disableCreateDatabase) {
       // capitalize first char of the err msg
       this.payload.logger.info(
         `${err.message.charAt(0).toUpperCase() + err.message.slice(1)}, creating...`,
       )
       const isCreated = await this.createDatabase()
 
-      if (isCreated) {
+      if (isCreated && this.connect) {
         await this.connect(options)
         return
       }
@@ -116,6 +117,6 @@ export const connect: Connect = async function connect(
   }
 
   if (process.env.NODE_ENV === 'production' && this.prodMigrations) {
-    await this.migrate({ migrations: this.prodMigrations })
+    await this.migrate({ migrations: this.prodMigrations as unknown as Migration[] })
   }
 }

packages/db-postgres/src/index.ts

@@ -79,13 +79,17 @@ export function postgresAdapter(args: Args): DatabaseAdapterObj<PostgresAdapter>
     if (args.schemaName) {
       adapterSchema = pgSchema(args.schemaName)
     } else {
+      // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve
       adapterSchema = { enum: pgEnum, table: pgTable }
     }
 
-    const extensions = (args.extensions ?? []).reduce((acc, name) => {
-      acc[name] = true
-      return acc
-    }, {})
+    const extensions = (args.extensions ?? []).reduce(
+      (acc, name) => {
+        acc[name] = true
+        return acc
+      },
+      {} as Record<string, boolean>,
+    )
 
     return createDatabaseAdapter<PostgresAdapter>({
       name: 'postgres',
@@ -102,6 +106,7 @@ export function postgresAdapter(args: Args): DatabaseAdapterObj<PostgresAdapter>
       }),
       defaultDrizzleSnapshot,
       disableCreateDatabase: args.disableCreateDatabase ?? false,
+      // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve
       drizzle: undefined,
       enums: {},
       extensions,
@@ -123,9 +128,11 @@ export function postgresAdapter(args: Args): DatabaseAdapterObj<PostgresAdapter>
       logger: args.logger,
       operators: operatorMap,
       pgSchema: adapterSchema,
+      // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve
       pool: undefined,
       poolOptions: args.pool,
       prodMigrations: args.prodMigrations,
+      // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve
       push: args.push,
       relations: {},
       relationshipsSuffix: args.relationshipsSuffix || '_rels',
@@ -163,6 +170,7 @@ export function postgresAdapter(args: Args): DatabaseAdapterObj<PostgresAdapter>
       find,
       findGlobal,
       findGlobalVersions,
+      // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve
       findOne,
       findVersions,
       indexes: new Set<string>(),
@@ -180,8 +188,10 @@ export function postgresAdapter(args: Args): DatabaseAdapterObj<PostgresAdapter>
       queryDrafts,
       rawRelations: {},
       rawTables: {},
+      // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve
       rejectInitializing,
       requireDrizzleKit,
+      // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve
       resolveInitializing,
       rollbackTransaction,
       updateGlobal,

packages/db-postgres/tsconfig.json

@@ -1,10 +1,5 @@
 {
   "extends": "../../tsconfig.base.json",
-  "compilerOptions": {
-    /* TODO: remove the following lines */
-    "strict": false,
-    "noUncheckedIndexedAccess": false,
-  },
   "references": [
     {
       "path": "../payload"