net: refactor logic branches

Author: araujogui

lib/internal/socketaddress.js

@@ -157,14 +157,19 @@ class SocketAddress {
       // url.port strips default HTTP ports (e.g. 80), so parse the port from
       // the raw input string instead.
       const { hostname: address } = URLParse(`http://${input}`);
-      if (address.startsWith('[') && address.endsWith(']')) {
-        const portStart = input.indexOf(']:');
-        const port = portStart !== -1 ? NumberParseInt(input.slice(portStart + 2), 10) || 0 : 0;
-        return new SocketAddress({ address: address.slice(1, -1), port, family: 'ipv6' });
-      }
-      const lastColon = input.lastIndexOf(':');
-      const port = lastColon !== -1 ? NumberParseInt(input.slice(lastColon + 1), 10) || 0 : 0;
-      return new SocketAddress({ address, port });
+
+      const isIPv6 = address.startsWith('[') && address.endsWith(']');
+
+      // For IPv6, indexOf(']:') + 1 points at ':' (or 0 if absent, treated as no port).
+      // For IPv4, lastIndexOf(':') points at ':' (or -1 if absent).
+      const sepIdx = isIPv6 ? input.indexOf(']:') + 1 : input.lastIndexOf(':');
+      const port = sepIdx > 0 ? NumberParseInt(input.slice(sepIdx + 1), 10) || 0 : 0;
+
+      return new SocketAddress({
+        address: isIPv6 ? address.slice(1, -1) : address,
+        port,
+        family: isIPv6 ? 'ipv6' : 'ipv4',
+      });
     } catch {
       // Ignore errors here. Return undefined if the input cannot
       // be successfully parsed or is not a proper socket address.