net: fix userinfo handling

Author: araujogui

lib/internal/socketaddress.js

@@ -160,10 +160,13 @@ class SocketAddress {
 
       const isIPv6 = address[0] === '[' && address.endsWith(']');
 
+      // Strip userinfo (e.g. "user:pass@") before searching for port separator.
       // For IPv6, indexOf(']:') + 1 points at ':' (or 0 if absent, treated as no port).
       // For IPv4, lastIndexOf(':') points at ':' (or -1 if absent).
-      const sepIdx = isIPv6 ? input.indexOf(']:') + 1 : input.lastIndexOf(':');
-      const port = sepIdx > 0 ? NumberParseInt(input.slice(sepIdx + 1), 10) || 0 : 0;
+      const atIdx = input.lastIndexOf('@');
+      const hostPart = atIdx >= 0 ? input.slice(atIdx + 1) : input;
+      const sepIdx = isIPv6 ? hostPart.indexOf(']:') + 1 : hostPart.lastIndexOf(':');
+      const port = sepIdx > 0 ? NumberParseInt(hostPart.slice(sepIdx + 1), 10) || 0 : 0;
 
       return new SocketAddress({
         address: isIPv6 ? address.slice(1, -1) : address,

test/parallel/test-socketaddress.js

@@ -152,6 +152,12 @@ describe('net.SocketAddress...', () => {
       { input: '127.0.0.1:443', address: '127.0.0.1', port: 443, family: 'ipv4' },
       { input: '[::1]:80', address: '::1', port: 80, family: 'ipv6' },
       { input: '[::1]:443', address: '::1', port: 443, family: 'ipv6' },
+      { input: 'user:80@1.2.3.4', address: '1.2.3.4', port: 0, family: 'ipv4' },
+      { input: 'user:80@1.2.3.4:80', address: '1.2.3.4', port: 80, family: 'ipv4' },
+      { input: 'user:80@1.2.3.4:123', address: '1.2.3.4', port: 123, family: 'ipv4' },
+      { input: 'user:80@[::1]', address: '::1', port: 0, family: 'ipv6' },
+      { input: 'user:80@[::1]:80', address: '::1', port: 80, family: 'ipv6' },
+      { input: 'user:80@[::1]:123', address: '::1', port: 123, family: 'ipv6' },
     ];
 
     good.forEach((i) => {