deps: update V8 to 3.28.71.19

The 3.28.73 update was technically unstable code. This reverts the code
to the latest 3.28 stable release.

Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: nodejs/node-v0.x-archive#18206

Author: trevnorris

deps/v8/ChangeLog

@@ -1,8 +1,3 @@
-2014-08-13: Version 3.28.73
-
-        Performance and stability improvements on all platforms.
-
-
 2014-08-12: Version 3.28.71
 
         ToNumber(Symbol) should throw TypeError (issue 3499).

deps/v8/build/features.gypi

@@ -115,7 +115,7 @@
       'Release': {
         'variables': {
           'v8_enable_extra_checks%': 0,
-          'v8_enable_handle_zapping%': 1,
+          'v8_enable_handle_zapping%': 0,
         },
         'conditions': [
           ['v8_enable_extra_checks==1', {

deps/v8/include/v8.h

@@ -4186,17 +4186,6 @@ class V8_EXPORT Isolate {
    */
   static Isolate* GetCurrent();
 
-  /**
-   * Custom callback used by embedders to help V8 determine if it should abort
-   * when it throws and no internal handler can catch the exception.
-   * If FLAG_abort_on_uncaught_exception is true, then V8 will abort if either:
-   * - no custom callback is set.
-   * - the custom callback set returns true.
-   * Otherwise it won't abort.
-   */
-  typedef bool (*abort_on_uncaught_exception_t)();
-  void SetAbortOnUncaughtException(abort_on_uncaught_exception_t callback);
-
   /**
    * Methods below this point require holding a lock (using Locker) in
    * a multi-threaded environment.

deps/v8/src/api.cc

@@ -5543,6 +5543,11 @@ bool v8::String::CanMakeExternal() {
   i::Handle<i::String> obj = Utils::OpenHandle(this);
   i::Isolate* isolate = obj->GetIsolate();
 
+  // TODO(yangguo): Externalizing sliced/cons strings allocates.
+  // This rule can be removed when all code that can
+  // trigger an access check is handlified and therefore GC safe.
+  if (isolate->heap()->old_pointer_space()->Contains(*obj)) return false;
+
   if (isolate->string_tracker()->IsFreshUnusedString(obj)) return false;
   int size = obj->Size();  // Byte size of the original string.
   if (size < i::ExternalString::kShortSize) return false;
@@ -6731,6 +6736,7 @@ void v8::Isolate::LowMemoryNotification() {
   }
 }
 
+
 int v8::Isolate::ContextDisposedNotification() {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
   return isolate->heap()->NotifyContextDisposed();

deps/v8/src/array-iterator.js

@@ -120,8 +120,8 @@ function ExtendArrayPrototype() {
   %CheckIsBootstrapping();
 
   InstallFunctions($Array.prototype, DONT_ENUM, $Array(
+    // No 'values' since it breaks webcompat: http://crbug.com/409858
     'entries', ArrayEntries,
-    'values', ArrayValues,
     'keys', ArrayKeys
   ));
 

deps/v8/src/array.js

@@ -1480,7 +1480,6 @@ function SetUpArray() {
     find: true,
     findIndex: true,
     keys: true,
-    values: true,
   };
   %AddNamedProperty($Array.prototype, symbolUnscopables, unscopables,
       DONT_ENUM | READ_ONLY);

deps/v8/src/base/platform/platform-posix.cc

@@ -321,15 +321,11 @@ int OS::GetCurrentProcessId() {
 
 
 int OS::GetCurrentThreadId() {
-#if V8_OS_MACOSX
-  return static_cast<int>(pthread_mach_thread_np(pthread_self()));
-#elif V8_OS_LINUX
+#if defined(ANDROID)
   return static_cast<int>(syscall(__NR_gettid));
-#elif V8_OS_ANDROID
-  return static_cast<int>(gettid());
 #else
-  return static_cast<int>(pthread_self());
-#endif
+  return static_cast<int>(syscall(SYS_gettid));
+#endif  // defined(ANDROID)
 }
 
 
@@ -608,8 +604,9 @@ void Thread::Join() {
 
 
 void Thread::YieldCPU() {
-  const timespec delay = { 0, 1 };
-  nanosleep(&delay, NULL);
+  int result = sched_yield();
+  DCHECK_EQ(0, result);
+  USE(result);
 }
 
 

deps/v8/src/base/platform/platform.h

@@ -35,7 +35,6 @@ namespace std {
 int signbit(double x);
 }
 # endif
-#include <alloca.h>
 #endif
 
 #if V8_OS_QNX

deps/v8/src/bootstrapper.cc

@@ -2655,17 +2655,19 @@ Genesis::Genesis(Isolate* isolate,
                                   NONE).Assert();
 
     // Initialize trigonometric lookup tables and constants.
-    const int constants_size = ARRAY_SIZE(fdlibm::MathConstants::constants);
+    const int constants_size =
+        ARRAY_SIZE(fdlibm::TrigonometricConstants::constants);
     const int table_num_bytes = constants_size * kDoubleSize;
     v8::Local<v8::ArrayBuffer> trig_buffer = v8::ArrayBuffer::New(
         reinterpret_cast<v8::Isolate*>(isolate),
-        const_cast<double*>(fdlibm::MathConstants::constants), table_num_bytes);
+        const_cast<double*>(fdlibm::TrigonometricConstants::constants),
+        table_num_bytes);
     v8::Local<v8::Float64Array> trig_table =
         v8::Float64Array::New(trig_buffer, 0, constants_size);
 
     Runtime::DefineObjectProperty(
         builtins,
-        factory()->InternalizeOneByteString(STATIC_ASCII_VECTOR("kMath")),
+        factory()->InternalizeOneByteString(STATIC_ASCII_VECTOR("kTrig")),
         Utils::OpenHandle(*trig_table), NONE).Assert();
   }
 

deps/v8/src/codegen.cc

@@ -190,7 +190,7 @@ void CodeGenerator::PrintCode(Handle<Code> code, CompilationInfo* info) {
             function->end_position() - function->start_position() + 1;
         for (int i = 0; i < source_len; i++) {
           if (stream.HasMore()) {
-            os << AsReversiblyEscapedUC16(stream.GetNext());
+            os << AsUC16(stream.GetNext());
           }
         }
         os << "\n\n";