Skip to content

Commit 1fde5f5

Browse files
felixgery
authored andcommitted
Make https 'timeout' events bubble up
Also adds a test case for it.
1 parent 9a3dd75 commit 1fde5f5

2 files changed

Lines changed: 56 additions & 0 deletions

File tree

lib/tls.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -876,10 +876,16 @@ function pipe(pair, socket) {
876876
function onclose() {
877877
socket.removeListener('error', onerror);
878878
socket.removeListener('close', onclose);
879+
socket.removeListener('timeout', ontimeout);
880+
}
881+
882+
function ontimeout() {
883+
cleartext.emit('timeout');
879884
}
880885

881886
socket.on('error', onerror);
882887
socket.on('close', onclose);
888+
socket.on('timeout', ontimeout);
883889

884890
return cleartext;
885891
}
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
22+
var common = require('../common');
23+
var assert = require('assert');
24+
var tls = require('tls');
25+
var fs = require('fs');
26+
27+
var hadTimeout = false;
28+
29+
var options = {
30+
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
31+
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
32+
};
33+
34+
var server = tls.Server(options, function(socket) {
35+
socket.setTimeout(100);
36+
37+
socket.on('timeout', function(err) {
38+
hadTimeout = true;
39+
socket.end();
40+
server.close();
41+
});
42+
});
43+
44+
server.listen(common.PORT, function() {
45+
var socket = tls.connect(common.PORT);
46+
});
47+
48+
process.on('exit', function() {
49+
assert.ok(hadTimeout);
50+
});

0 commit comments

Comments
 (0)