Commit 4b6f839
committed
Fix nan_weak.h for V8 >= 14.2.194 (missing EmbedderDataTypeTag)
Commit fcc7b7d added V8 >= 14.2.194 compatibility guards to nan.h for
GetAlignedPointerFromInternalField and SetAlignedPointerInInternalField
which now require an additional v8::kEmbedderDataTypeTagDefault tag
parameter. However, the same unguarded calls in nan_weak.h were missed,
causing build failures with Electron 41+ / V8 >= 14.2.194.
Apply the exact same preprocessor guard pattern to all occurrences in
nan_weak.h.1 parent 56bbc48 commit 4b6f839
1 file changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
279 | 286 | | |
| 287 | + | |
280 | 288 | | |
281 | 289 | | |
282 | 290 | | |
283 | 291 | | |
284 | 292 | | |
285 | 293 | | |
286 | 294 | | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
287 | 302 | | |
| 303 | + | |
288 | 304 | | |
289 | 305 | | |
290 | 306 | | |
| |||
0 commit comments