fix(files): use displayname rather than basename to use progress#60541
Merged
Conversation
susnux
added
bug
3. to review
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable34 |
skjnldsv
approved these changes
May 19, 2026
- resolves nextcloud/end_to_end_encryption#1733 The internal basename is often not known by users, e.g. groupfolders or in this case e2ee can define displaynames other than the shown name. Same for e.g. mount points of shares. So we need to show the displayname instead. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
|
/compile |
susnux
force-pushed
the
fix/use-displayname
branch
from
8b9d373 to
171ffb8
Compare
Contributor
Author
|
/backport to stable32 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The internal basename is often not known by users, e.g. groupfolders or in this case e2ee can define displaynames other than the shown name. Same for e.g. mount points of shares.
So we need to show the displayname instead.
Checklist
3. to review, feature component)stable32)AI (if applicable)