added IgnoreErrorExtension for runtime type validation pattern (function(Type ...$p) {})(...$args)

Author: dg

extension.neon

@@ -2,3 +2,8 @@ parameters:
 
 includes:
 	- extension-narrowReturnType.neon
+
+services:
+	-
+		class: Nette\PHPStan\Analyser\TypeValidationCallIgnoreExtension
+		tags: [phpstan.ignoreErrorExtension]

phpstan.neon

@@ -13,6 +13,12 @@ parameters:
 		-
 			identifiers: [phpstanApi.method]
 			path: src/Type/NarrowReturnTypeResolver.php
+		-
+			identifiers: [phpstanApi.class, phpstanApi.method]
+			path: src/Analyser/TypeValidationCallIgnoreExtension.php
+		-
+			identifiers: [phpstanApi.classConstant, phpstanApi.method]
+			path: src/Testing/TypeAssert.php
 
 includes:
 	- extension.neon

src/Analyser/TypeValidationCallIgnoreExtension.php

@@ -0,0 +1,47 @@
+<?php declare(strict_types=1);
+
+namespace Nette\PHPStan\Analyser;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\Closure;
+use PhpParser\Node\Expr\FuncCall;
+use PHPStan\Analyser\Error;
+use PHPStan\Analyser\IgnoreErrorExtension;
+use PHPStan\Analyser\Scope;
+use PHPStan\Node\NoopExpressionNode;
+
+
+/**
+ * Suppresses 'expr.resultUnused' for the runtime type validation pattern (function(Type ...$p) {})(...$args).
+ */
+class TypeValidationCallIgnoreExtension implements IgnoreErrorExtension
+{
+	public function shouldIgnore(Error $error, Node $node, Scope $scope): bool
+	{
+		if ($error->getIdentifier() !== 'expr.resultUnused') {
+			return false;
+		}
+
+		if (!$node instanceof NoopExpressionNode) {
+			return false;
+		}
+
+		$expr = $node->getOriginalExpr();
+		if (!$expr instanceof FuncCall || !$expr->name instanceof Closure) {
+			return false;
+		}
+
+		$closure = $expr->name;
+		if ($closure->stmts !== [] || $closure->params === []) {
+			return false;
+		}
+
+		foreach ($closure->params as $param) {
+			if (!$param->variadic || $param->type === null) {
+				return false;
+			}
+		}
+
+		return true;
+	}
+}

src/Tester/TypeAssert.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Name;
+use PHPStan\Analyser\Analyser;
 use PHPStan\Analyser\NodeScopeResolver;
 use PHPStan\Analyser\Scope;
 use PHPStan\Analyser\ScopeContext;
@@ -71,6 +72,30 @@ static function (Node $node, Scope $scope) use (&$asserts): void {
 	}
 
 
+	/**
+	 * Analyses a PHP file and verifies that PHPStan reports no errors.
+	 * @param list<string> $configFiles
+	 */
+	public static function assertNoErrors(string $file, array $configFiles = []): void
+	{
+		$container = self::createContainer($configFiles);
+
+		$fileHelper = $container->getByType(FileHelper::class);
+		$file = $fileHelper->normalizePath($file);
+
+		$container->getService('pathRoutingParser')->setAnalysedFiles([$file]);
+
+		$analyser = $container->getByType(Analyser::class);
+		$result = $analyser->analyse([$file]);
+
+		$errors = array_map(
+			static fn($e) => $e->getIdentifier() . ' on line ' . $e->getLine(),
+			$result->getErrors(),
+		);
+		Assert::same([], $errors);
+	}
+
+
 	/**
 	 * @return array{expected: string, actual: string, line: int}|null
 	 */

tests/TypeValidationCallIgnoreTest.phpt

@@ -0,0 +1,7 @@
+<?php declare(strict_types=1);
+
+require __DIR__ . '/bootstrap.php';
+
+use Nette\PHPStan\Tester\TypeAssert;
+
+TypeAssert::assertNoErrors(__DIR__ . '/data/type-validation-call.php', [__DIR__ . '/../extension.neon']);

tests/data/type-validation-call.php

@@ -0,0 +1,11 @@
+<?php declare(strict_types=1);
+
+
+class Foo
+{
+	/** @param string[] $items */
+	public function setItems(array $items): void
+	{
+		(function (string ...$items) {})(...$items);
+	}
+}