Conversation
Because:
* After a THROTTLED (errno 114) response on the OTP code-entry
screens, the Confirm and "Email new code" buttons stayed
clickable, letting users fire requests guaranteed to fail.
This commit:
* Adds a useThrottle hook that disables retry controls for the
server's retryAfter window (a v2 rate-limit value, in
milliseconds) and re-enables them when it elapses.
* Adds an isThrottled prop to FormVerifyCode and disables the
resend button on SigninTokenCode, SigninPasswordlessCode, and
ConfirmSignupCode.
* Ignores a missing or invalid retryAfter so controls never lock
with no visible reason; the error banner remains the signal.
44d0ecd to
ee40cce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
useThrottleCountdownhook that counts downretryAfterseconds, or stays throttled when onlyretryAfterLocalizedis present.throttleSecondsRemainingandthrottleLocalizedFallbackprops toFormVerifyCode. The submit button is disabled while throttled, and anaria-live="polite"region shows "Try again in N seconds".SigninTokenCode,SigninPasswordlessCode, andConfirmSignupCodeon their THROTTLED branches, and disables each page's "Email new code" button for the same window.form-verify-code-throttled-countdownandform-verify-code-throttled-generic.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-13742
Checklist
Put an
xin the boxes that apply