Skip to content

Fix no tests being run when flowsOrder specified all tests in the workspace#2003

Merged
bartekpacia merged 16 commits intomainfrom
fix/flows_order
Sep 3, 2024
Merged

Fix no tests being run when flowsOrder specified all tests in the workspace#2003
bartekpacia merged 16 commits intomainfrom
fix/flows_order

Conversation

@bartekpacia
Copy link
Copy Markdown
Contributor

Attempts to fix #1971

@bartekpacia
Copy link
Copy Markdown
Contributor Author

Investigation results

This bug is introduced by #1732. Offending source code:

https://github.com/mobile-dev-inc/maestro/blob/a9575c5b1ce8ee13d549449e6887e5a1ec4caae4/maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt#L197-L198

It occurs only when all flows are specified in executionOrder.flowsOrder. Take this config.yaml as an example:

flows:
  - "features/**"
includeTags:
  - regression
executionOrder:
    continueOnFailure: true
    flowsOrder:
        - test1
        - test2
        - test3

If in features/ there is only test1.yaml, test2.yaml, and test3.yaml, then the bug occurs. But if we add test_other.yaml, then the bug is fixed.

Fix: when running in a single shard, add ExecutionPlan.sequence at the beginning of the queue of flows to execute.

Also, I'd like to have a bit more output logging.

@bartekpacia bartekpacia changed the title Start reproducing flowsOrder not working Fix no tests being run when flowsOrder specified all tests in the workspace Sep 3, 2024
@bartekpacia bartekpacia merged commit 3384806 into main Sep 3, 2024
@bartekpacia bartekpacia deleted the fix/flows_order branch September 3, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flowsOrder doesn't work in 1.37.9

1 participant