Add html_url attribute to comments.#170
Merged
jacquev6 merged 1 commit intoPyGithub:developfrom May 31, 2013
Merged
Conversation
html_url attributes were missing from IssueComment and PullRequestComment. Added to both as per the GitHub API.
Member
|
Thank you for your contribution! |
jacquev6
added a commit
that referenced
this pull request
May 31, 2013
I just modified the ReplayData manually and added a "get" in the tests.
Member
|
Published in version 1.16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
html_url attributes were missing from IssueComment and PullRequestComment.
Added to both as per the GitHub API.
I made an attempt to add some tests, but I couldn't get the replay data recorded correctly.
Errors I received were:
a) Issues are disabled for this repo.
b) Not found.
My apologies.