Skip to content

Commit 9736cb3

Browse files
kabergregkh
authored andcommitted
netfilter: nf_ct_sip: don't drop packets with offsets pointing outside the packet
commit 3a7b21e upstream. Some Cisco phones create huge messages that are spread over multiple packets. After calculating the offset of the SIP body, it is validated to be within the packet and the packet is dropped otherwise. This breaks operation of these phones. Since connection tracking is supposed to be passive, just let those packets pass unmodified and untracked. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Cc: William Roberts <bill.c.roberts@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 1ddb811 commit 9736cb3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/netfilter/nf_conntrack_sip.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1468,7 +1468,7 @@ static int sip_help_tcp(struct sk_buff *skb, unsigned int protoff,
14681468

14691469
msglen = origlen = end - dptr;
14701470
if (msglen > datalen)
1471-
return NF_DROP;
1471+
return NF_ACCEPT;
14721472

14731473
ret = process_sip_msg(skb, ct, dataoff, &dptr, &msglen);
14741474
if (ret != NF_ACCEPT)

0 commit comments

Comments
 (0)