Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

Commit c3b5907

Browse files
author
Ilya Gurov
authored
fix: Spanner auto managed indexes should not be introspected (#241)
1 parent f23e599 commit c3b5907

3 files changed

Lines changed: 16 additions & 0 deletions

File tree

google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,9 @@ def get_indexes(self, connection, table_name, schema=None, **kw):
689689
WHERE
690690
i.table_name="{table_name}"
691691
AND i.index_type != 'PRIMARY_KEY'
692+
AND i.spanner_is_managed = FALSE
692693
GROUP BY i.index_name, i.is_unique
694+
ORDER BY i.index_name
693695
""".format(
694696
table_name=table_name
695697
)

test/test_suite_13.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -939,6 +939,13 @@ def test_array_reflection(self):
939939

940940
tab.drop()
941941

942+
def _assert_insp_indexes(self, indexes, expected_indexes):
943+
expected_indexes.sort(key=lambda item: item["name"])
944+
945+
index_names = [d["name"] for d in indexes]
946+
exp_index_names = [d["name"] for d in expected_indexes]
947+
assert sorted(index_names) == sorted(exp_index_names)
948+
942949

943950
class CompositeKeyReflectionTest(_CompositeKeyReflectionTest):
944951
@testing.requires.foreign_key_constraint_reflection

test/test_suite_14.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -701,6 +701,13 @@ def test_get_temp_table_unique_constraints(self):
701701
def test_get_temp_table_columns(self):
702702
pass
703703

704+
def _assert_insp_indexes(self, indexes, expected_indexes):
705+
expected_indexes.sort(key=lambda item: item["name"])
706+
707+
index_names = [d["name"] for d in indexes]
708+
exp_index_names = [d["name"] for d in expected_indexes]
709+
assert sorted(index_names) == sorted(exp_index_names)
710+
704711

705712
class CompositeKeyReflectionTest(_CompositeKeyReflectionTest):
706713
@testing.requires.foreign_key_constraint_reflection

0 commit comments

Comments
 (0)