Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Commit 6973e51

Browse files
authored
Merge pull request #2453 from dhermes/upgrade-gapic-deps
Upgrading versions of GAPIC and gRPC generated libraries.
2 parents 10c3008 + 9c3006e commit 6973e51

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

google/cloud/pubsub/_gax.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,8 @@ def subscription_create(self, subscription_path, topic_path,
293293

294294
try:
295295
sub_pb = self._gax_api.create_subscription(
296-
subscription_path, topic_path, push_config, ack_deadline)
296+
subscription_path, topic_path,
297+
push_config=push_config, ack_deadline_seconds=ack_deadline)
297298
except GaxError as exc:
298299
if exc_to_code(exc.cause) == StatusCode.FAILED_PRECONDITION:
299300
raise Conflict(topic_path)
@@ -391,7 +392,8 @@ def subscription_pull(self, subscription_path, return_immediately=False,
391392
"""
392393
try:
393394
response_pb = self._gax_api.pull(
394-
subscription_path, max_messages, return_immediately)
395+
subscription_path, max_messages,
396+
return_immediately=return_immediately)
395397
except GaxError as exc:
396398
if exc_to_code(exc.cause) == StatusCode.NOT_FOUND:
397399
raise NotFound(subscription_path)

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@
5353
'google-cloud-core >= 0.20.0',
5454
'grpcio >= 1.0.0, < 2.0dev',
5555
'google-gax >= 0.14.1, < 0.15dev',
56-
'gapic-google-pubsub-v1 >= 0.9.0, < 0.10dev',
57-
'grpc-google-pubsub-v1 >= 0.9.0, < 0.10dev',
56+
'gapic-google-pubsub-v1 >= 0.10.1, < 0.11dev',
57+
'grpc-google-pubsub-v1 >= 0.10.1, < 0.11dev',
5858
]
5959

6060
setup(

0 commit comments

Comments
 (0)