Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Commit 2bea5ee

Browse files
committed
chore: raise error explicitly for AllOp with windows
1 parent f7fd2d2 commit 2bea5ee

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

bigframes/core/compile/ibis_compiler/aggregate_compiler.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -633,6 +633,9 @@ def _(
633633
column: ibis_types.Column,
634634
window=None,
635635
) -> ibis_types.BooleanValue:
636+
if window is not None:
637+
raise NotImplementedError("AllOp with windowing is not supported.")
638+
636639
# BQ will return null for empty column, result would be false in pandas.
637640
result = _apply_window_if_present(_is_true(column).all(), window)
638641
literal = ibis_types.literal(True)

bigframes/core/compile/sqlglot/aggregations/unary_compiler.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ def _(
4444
column: typed_expr.TypedExpr,
4545
window: typing.Optional[window_spec.WindowSpec] = None,
4646
) -> sge.Expression:
47+
# if window is not None:
48+
# raise NotImplementedError("AllOp with windowing is not supported.")
49+
4750
# BQ will return null for empty column, result would be false in pandas.
4851
result = apply_window_if_present(sge.func("LOGICAL_AND", column.expr), window)
4952
return sge.func("IFNULL", result, sge.true())

0 commit comments

Comments
 (0)