chore(tool/cmd/migrate): do not block release in config.yaml (#4647)

Do not set `ReleaseBlocked` for libraries in config.yaml because we
still rely on legacylibrarian to release the libraries.

For #3618

Author: JoeWang1127

tool/cmd/migrate/legacylibrarian.go

@@ -109,7 +109,7 @@ func runLibrarianMigration(ctx context.Context, language string, repoPath string
 	if err := librarian.RunTidyOnConfig(ctx, repoPath, cfg); err != nil {
 		return errTidyFailed
 	}
-	if err := blockLegacyGenerationAndRelease(repoPath, cfg); err != nil {
+	if err := blockLegacyGeneration(repoPath, cfg); err != nil {
 		return err
 	}
 	return nil
@@ -204,12 +204,11 @@ func buildConfigFromLibrarian(ctx context.Context, input *MigrationInput) (*conf
 	return cfg, nil
 }
 
-// blockLegacyGenerationAndRelease ensures that all libraries in the librarian
-// config have generation and release blocked in the legacy config, by rewriting
-// .librarian/config.yaml. This was previously a file maintained by hand, so a
-// comment line is added at the start. This function assumes that the current
-// directory is the repository root.
-func blockLegacyGenerationAndRelease(repoPath string, cfg *config.Config) error {
+// blockLegacyGeneration ensures that all libraries in the librarian config have generation blocked in the legacy
+// config, by rewriting .librarian/config.yaml.
+// This was previously a file maintained by hand, so a comment line is added at the start. This function assumes that
+// the current directory is the repository root.
+func blockLegacyGeneration(repoPath string, cfg *config.Config) error {
 	legacyConfig, err := readLegacyConfig(repoPath)
 	if err != nil {
 		return err
@@ -223,7 +222,6 @@ func blockLegacyGenerationAndRelease(repoPath string, cfg *config.Config) error
 			legacyConfig.Libraries = append(legacyConfig.Libraries, legacyLib)
 		}
 		legacyLib.GenerateBlocked = true
-		legacyLib.ReleaseBlocked = true
 	}
 	configYaml, err := yaml.Marshal(legacyConfig)
 	if err != nil {

tool/cmd/migrate/legacylibrarian_test.go

@@ -1160,7 +1160,7 @@ func TestToAPIs(t *testing.T) {
 	}
 }
 
-func TestBlockLegacyGenerationAndRelease(t *testing.T) {
+func TestBlockLegacyGeneration(t *testing.T) {
 	tempDir := t.TempDir()
 	if err := os.Mkdir(filepath.Join(tempDir, librarianDir), 0755); err != nil {
 		t.Fatal(err)
@@ -1196,7 +1196,7 @@ func TestBlockLegacyGenerationAndRelease(t *testing.T) {
 			{Name: "migrated"},
 		},
 	}
-	if err := blockLegacyGenerationAndRelease(tempDir, migratedConfig); err != nil {
+	if err := blockLegacyGeneration(tempDir, migratedConfig); err != nil {
 		t.Fatal(err)
 	}
 	wantConfig := &legacyconfig.LibrarianConfig{
@@ -1212,18 +1212,15 @@ func TestBlockLegacyGenerationAndRelease(t *testing.T) {
 			{
 				LibraryID:       "migrated-already-generate-blocked",
 				GenerateBlocked: true,
-				ReleaseBlocked:  true,
 			},
 			{
 				LibraryID:       "migrated",
 				NextVersion:     "1.2.3",
 				GenerateBlocked: true,
-				ReleaseBlocked:  true,
 			},
 			{
 				LibraryID:       "not-previously-in-config",
 				GenerateBlocked: true,
-				ReleaseBlocked:  true,
 			},
 		},
 	}
@@ -1236,13 +1233,13 @@ func TestBlockLegacyGenerationAndRelease(t *testing.T) {
 	}
 }
 
-func TestBlockLegacyGenerationAndRelease_Error(t *testing.T) {
+func TestBlockLegacyGeneration_Error(t *testing.T) {
 	tempDir := t.TempDir()
 	migratedConfig := &config.Config{}
-	gotErr := blockLegacyGenerationAndRelease(tempDir, migratedConfig)
+	gotErr := blockLegacyGeneration(tempDir, migratedConfig)
 	wantErr := os.ErrNotExist
 	if !errors.Is(gotErr, wantErr) {
-		t.Errorf("blockLegacyGenerationAndRelease error = %v, wantErr %v", gotErr, wantErr)
+		t.Errorf("blockLegacyGeneration error = %v, wantErr %v", gotErr, wantErr)
 	}
 }