Skip to content

Commit e328d50

Browse files
committed
Merge pull request #1350 from dhermes/use-travis-caching
Removing use of wheelhouse and relying on Travis caching.
2 parents d5bbb14 + d039bde commit e328d50

7 files changed

Lines changed: 16 additions & 107 deletions

File tree

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ system_tests/local_test_setup
5050
# Make sure a generated file isn't accidentally committed.
5151
pylintrc_reduced
5252

53-
# Travis build directories.
54-
gcloud-python-wheels/
55-
5653
# Directories used for creating generated PB2 files
5754
generated_python/
5855
cloud-bigtable-client/

.travis.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
language: python
22
sudo: false
33

4-
before_install:
5-
- git clone https://github.com/GoogleCloudPlatform/gcloud-python-wheels
6-
gcloud-python-wheels
7-
- export WHEELHOUSE="$(pwd)/gcloud-python-wheels/wheelhouse/"
8-
94
install:
10-
- scripts/custom_pip_install.sh tox
5+
- pip install --upgrade pip
6+
- pip install --upgrade tox
117

128
script:
139
- tox -e py26
@@ -32,3 +28,7 @@ deploy:
3228
# until this is fixed: https://github.com/travis-ci/travis-ci/issues/1675
3329
all_branches: true
3430
distributions: "sdist bdist_wheel"
31+
32+
cache:
33+
directories:
34+
- ${HOME}/.cache/pip

CONTRIBUTING.rst

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -283,22 +283,18 @@ Python dependencies are specified in the ``tox.ini`` configuration.
283283
They are executed in the Travis build via ``tox -e {ENV}`` where
284284
``{ENV}`` is the environment being tested.
285285

286-
By enumerating all Python dependencies in the ``tox`` configuration,
287-
we can use our custom ``gcloud-python-wheels``
288-
`wheelhouse <https://github.com/GoogleCloudPlatform/gcloud-python-wheels>`__
289-
to speed up builds. This project builds and stores pre-built Python
290-
`wheels <http://pythonwheels.com>`__ for every Python dependency our library
291-
and tests have.
292-
293286
If new ``tox`` environments are added to be run in a Travis build, they
294-
should either be:
287+
should be listed in ``[tox].envlist`` as a default environment.
288+
289+
We speed up builds by using the Travis `caching feature`_.
295290

296-
- listed in ``[tox].envlist`` as a default environment
291+
.. _caching feature: https://docs.travis-ci.com/user/caching/#pip-cache
297292

298-
- added to the list in the
299-
`Travis environment variable <http://docs.travis-ci.com/user/environment-variables/#Using-Settings>`__
300-
``EXTRA_TOX_ENVS``. This value is unencrypted in ``gcloud-python-wheels``
301-
to make ongoing maintenance easier.
293+
We intentionally **do not** cache the ``.tox/`` directory. Instead, we
294+
allow the ``tox`` environments to be re-built for every build. This
295+
way, we'll always get the latest versions of our dependencies and any
296+
caching or wheel optimization to be done will be handled automatically
297+
by ``pip``.
302298

303299
Supported Python Versions
304300
-------------------------

scripts/custom_pip_install.sh

Lines changed: 0 additions & 21 deletions
This file was deleted.

scripts/merge.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ set -ev
2121
##############################################
2222
if [[ "${TRAVIS_BRANCH}" == "master" ]] && \
2323
[[ "${TRAVIS_PULL_REQUEST}" == "false" ]]; then
24+
echo "Building new docs on a merged commit."
2425
scripts/update_docs.sh
25-
scripts/update_wheels_project.sh
2626
elif [[ -n "${TRAVIS_TAG}" ]]; then
2727
echo "Building new docs on a tag."
2828
scripts/update_docs.sh

scripts/update_wheels_project.sh

Lines changed: 0 additions & 61 deletions
This file was deleted.

tox.ini

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ envlist =
33
py26,py27,py33,py34,cover,docs,lint
44

55
[testenv]
6-
install_command =
7-
{toxinidir}/scripts/custom_pip_install.sh {opts} {packages}
86
commands =
97
nosetests
108
deps =

0 commit comments

Comments
 (0)