Skip to content

Commit c32656e

Browse files
committed
Fix datastore: unprefixed ids in client test (pep8)
1 parent 2a212a5 commit c32656e

1 file changed

Lines changed: 18 additions & 11 deletions

File tree

gcloud/datastore/test_client.py

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ def test_get_multi_hit_multiple_keys_different_dataset(self):
494494
with self.assertRaises(ValueError):
495495
client.get_multi([key1, key2])
496496

497-
def test_get_multi_hit_multiple_keys_different_dataset_prefixes(self):
497+
def test_get_multi_diff_prefixes(self):
498498
from gcloud.datastore.key import Key
499499

500500
DATASET_ID1 = 'DATASET'
@@ -505,11 +505,6 @@ def test_get_multi_hit_multiple_keys_different_dataset_prefixes(self):
505505
ID2 = 2345
506506
ID3 = 3456
507507

508-
# Make sure our IDs are actually different.
509-
self.assertNotEqual(DATASET_ID1, DATASET_ID2)
510-
self.assertNotEqual(DATASET_ID1, DATASET_ID3)
511-
self.assertNotEqual(DATASET_ID2, DATASET_ID3)
512-
513508
# Make found entity pbs to be returned from mock backend.
514509
entity_pb1 = _make_entity_pb(DATASET_ID1, KIND, ID1)
515510
entity_pb2 = _make_entity_pb(DATASET_ID2, KIND, ID2)
@@ -518,8 +513,8 @@ def test_get_multi_hit_multiple_keys_different_dataset_prefixes(self):
518513
creds = object()
519514
client = self._makeOne(credentials=creds)
520515
client.connection._add_lookup_result([entity_pb1,
521-
entity_pb2,
522-
entity_pb3])
516+
entity_pb2,
517+
entity_pb3])
523518

524519
key1 = Key(KIND, ID1, dataset_id=DATASET_ID1)
525520
key2 = Key(KIND, ID2, dataset_id=DATASET_ID2)
@@ -530,11 +525,23 @@ def test_get_multi_hit_multiple_keys_different_dataset_prefixes(self):
530525

531526
# Check values & keys match.
532527
self.assertEqual(retrieved1.key.path, key1.path)
533-
self.assertEqual(dict(retrieved1), {})
534528
self.assertEqual(retrieved2.key.path, key2.path)
535-
self.assertEqual(dict(retrieved2), {})
536529
self.assertEqual(retrieved3.key.path, key3.path)
537-
self.assertEqual(dict(retrieved3), {})
530+
531+
def test_get_multi_diff_datasets_w_prefix(self):
532+
from gcloud.datastore.key import Key
533+
534+
DATASET_ID1 = 'e~DATASET'
535+
DATASET_ID2 = 's~DATASET-ALT'
536+
537+
key1 = Key('KIND', 1234, dataset_id=DATASET_ID1)
538+
key2 = Key('KIND', 1234, dataset_id=DATASET_ID2)
539+
540+
creds = object()
541+
client = self._makeOne(credentials=creds)
542+
543+
with self.assertRaises(ValueError):
544+
client.get_multi([key1, key2])
538545

539546
def test_get_multi_max_loops(self):
540547
from gcloud._testing import _Monkey

0 commit comments

Comments
 (0)