Increase unit test coverage.

Author: tswast

bigquery/google/cloud/bigquery/dataset.py

@@ -22,6 +22,7 @@
 import google.cloud._helpers
 from google.cloud.bigquery import _helpers
 from google.cloud.bigquery.model import ModelReference
+from google.cloud.bigquery.routine import RoutineReference
 from google.cloud.bigquery.table import TableReference
 
 
@@ -53,6 +54,25 @@ def _get_model_reference(self, model_id):
     )
 
 
+def _get_routine_reference(self, routine_id):
+    """Constructs a RoutineReference.
+
+    Args:
+        routine_id (str): the ID of the routine.
+
+    Returns:
+        google.cloud.bigquery.routine.RoutineReference:
+            A RoutineReference for a routine in this dataset.
+    """
+    return RoutineReference.from_api_repr(
+        {
+            "projectId": self.project,
+            "datasetId": self.dataset_id,
+            "routineId": routine_id,
+        }
+    )
+
+
 class AccessEntry(object):
     """Represents grant of an access role to an entity.
 
@@ -224,6 +244,8 @@ def path(self):
 
     model = _get_model_reference
 
+    routine = _get_routine_reference
+
     @classmethod
     def from_api_repr(cls, resource):
         """Factory: construct a dataset reference given its API representation
@@ -591,6 +613,8 @@ def _build_resource(self, filter_fields):
 
     model = _get_model_reference
 
+    routine = _get_routine_reference
+
     def __repr__(self):
         return "Dataset({})".format(repr(self.reference))
 
@@ -672,3 +696,5 @@ def reference(self):
     table = _get_table_reference
 
     model = _get_model_reference
+
+    routine = _get_routine_reference

bigquery/google/cloud/bigquery/routine.py

@@ -189,15 +189,19 @@ def return_type(self):
         https://cloud.google.com/bigquery/docs/reference/rest/v2/routines#resource-routine
         """
         resource = self._properties.get(self._PROPERTY_TO_API_FIELD["return_type"])
+        if not resource:
+            return resource
         output = google.cloud.bigquery_v2.types.StandardSqlDataType()
         output = json_format.ParseDict(resource, output, ignore_unknown_fields=True)
         return output
 
     @return_type.setter
     def return_type(self, value):
-        self._properties[
-            self._PROPERTY_TO_API_FIELD["return_type"]
-        ] = json_format.MessageToDict(value)
+        if value:
+            resource = json_format.MessageToDict(value)
+        else:
+            resource = None
+        self._properties[self._PROPERTY_TO_API_FIELD["return_type"]] = resource
 
     @property
     def imported_libraries(self):
@@ -257,6 +261,11 @@ def _build_resource(self, filter_fields):
         """Generate a resource for ``update``."""
         return _helpers._build_resource_from_properties(self, filter_fields)
 
+    def __repr__(self):
+        return "Routine('{}.{}.{}')".format(
+            self.project, self.dataset_id, self.routine_id
+        )
+
 
 class RoutineArgument(object):
     """Input/output argument of a function or a stored procedure.
@@ -328,15 +337,19 @@ def data_type(self):
         https://cloud.google.com/bigquery/docs/reference/rest/v2/StandardSqlDataType
         """
         resource = self._properties.get(self._PROPERTY_TO_API_FIELD["data_type"])
+        if not resource:
+            return resource
         output = google.cloud.bigquery_v2.types.StandardSqlDataType()
         output = json_format.ParseDict(resource, output, ignore_unknown_fields=True)
         return output
 
     @data_type.setter
     def data_type(self, value):
-        self._properties[
-            self._PROPERTY_TO_API_FIELD["data_type"]
-        ] = json_format.MessageToDict(value)
+        if value:
+            resource = json_format.MessageToDict(value)
+        else:
+            resource = None
+        self._properties[self._PROPERTY_TO_API_FIELD["data_type"]] = resource
 
     @classmethod
     def from_api_repr(cls, resource):
@@ -374,7 +387,7 @@ def __ne__(self, other):
     def __repr__(self):
         all_properties = [
             "{}={}".format(property_name, repr(getattr(self, property_name)))
-            for property_name in self._PROPERTY_TO_API_FIELD
+            for property_name in sorted(self._PROPERTY_TO_API_FIELD)
         ]
         return "RoutineArgument({})".format(", ".join(all_properties))
 

bigquery/samples/update_routine.py

@@ -35,6 +35,7 @@ def main(client, routine_id):
             # Due to a limitation of the API, all fields are required, not just
             # those that have been updated.
             "arguments",
+            "language",
             "type_",
             "return_type",
         ],