Skip to content

Commit a62b676

Browse files
henribruparthea
andauthored
fix: add context manager return types (#1468)
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
1 parent 128734b commit a62b676

9 files changed

Lines changed: 9 additions & 9 deletions

File tree

  • packages/gapic-generator
    • gapic
      • ads-templates/%namespace/%name/%version/%sub/services/%service
      • templates/%namespace/%name_%version/%sub/services/%service
    • tests/integration/goldens
      • asset/google/cloud/asset_v1/services/asset_service
      • credentials/google/iam/credentials_v1/services/iam_credentials
      • eventarc/google/cloud/eventarc_v1/services/eventarc
      • logging/google/cloud/logging_v2/services
      • redis/google/cloud/redis_v1/services/cloud_redis

packages/gapic-generator/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
175175
"""
176176
return self._transport
177177

178-
def __enter__(self):
178+
def __enter__(self) -> "{{ service.client_name }}":
179179
return self
180180

181181
def __exit__(self, type, value, traceback):

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
379379
{% endif %}
380380
{% endfor %}
381381

382-
def __enter__(self):
382+
def __enter__(self) -> "{{ service.client_name }}":
383383
return self
384384

385385
def __exit__(self, type, value, traceback):

packages/gapic-generator/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1833,7 +1833,7 @@ def sample_analyze_iam_policy_longrunning():
18331833
# Done; return the response.
18341834
return response
18351835

1836-
def __enter__(self):
1836+
def __enter__(self) -> "AssetServiceClient":
18371837
return self
18381838

18391839
def __exit__(self, type, value, traceback):

packages/gapic-generator/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -958,7 +958,7 @@ def sample_sign_jwt():
958958
# Done; return the response.
959959
return response
960960

961-
def __enter__(self):
961+
def __enter__(self) -> "IAMCredentialsClient":
962962
return self
963963

964964
def __exit__(self, type, value, traceback):

packages/gapic-generator/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1034,7 +1034,7 @@ def sample_delete_trigger():
10341034
# Done; return the response.
10351035
return response
10361036

1037-
def __enter__(self):
1037+
def __enter__(self) -> "EventarcClient":
10381038
return self
10391039

10401040
def __exit__(self, type, value, traceback):

packages/gapic-generator/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2831,7 +2831,7 @@ def sample_update_cmek_settings():
28312831
# Done; return the response.
28322832
return response
28332833

2834-
def __enter__(self):
2834+
def __enter__(self) -> "ConfigServiceV2Client":
28352835
return self
28362836

28372837
def __exit__(self, type, value, traceback):

packages/gapic-generator/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1113,7 +1113,7 @@ def request_generator():
11131113
# Done; return the response.
11141114
return response
11151115

1116-
def __enter__(self):
1116+
def __enter__(self) -> "LoggingServiceV2Client":
11171117
return self
11181118

11191119
def __exit__(self, type, value, traceback):

packages/gapic-generator/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,7 @@ def sample_delete_log_metric():
961961
metadata=metadata,
962962
)
963963

964-
def __enter__(self):
964+
def __enter__(self) -> "MetricsServiceV2Client":
965965
return self
966966

967967
def __exit__(self, type, value, traceback):

packages/gapic-generator/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1596,7 +1596,7 @@ def sample_delete_instance():
15961596
# Done; return the response.
15971597
return response
15981598

1599-
def __enter__(self):
1599+
def __enter__(self) -> "CloudRedisClient":
16001600
return self
16011601

16021602
def __exit__(self, type, value, traceback):

0 commit comments

Comments
 (0)