Skip to content

Commit 932a0ce

Browse files
authored
Merge pull request #2331 from dhermes/fix-2274
Loosening salience assumptions in language system test.
2 parents ca4f024 + 0bc8de4 commit 932a0ce

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

system_tests/language.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,25 +73,23 @@ def _check_analyze_entities_result(self, entities):
7373
# Verify entity 1.
7474
self.assertEqual(entity1.name, self.NAME1)
7575
self.assertEqual(entity1.entity_type, EntityType.PERSON)
76-
# NOTE: As of Sept. 8, 2016, entity1.salience == 0.81992269
77-
self.assertTrue(0.6 < entity1.salience < 1.0)
76+
self.assertGreater(entity1.salience, 0.0)
7877
self.assertEqual(entity1.mentions, [entity1.name])
7978
self.assertEqual(entity1.wikipedia_url,
8079
'http://en.wikipedia.org/wiki/Caravaggio')
8180
self.assertEqual(entity1.metadata, {})
8281
# Verify entity 2.
8382
self.assertEqual(entity2.name, self.NAME2)
8483
self.assertEqual(entity2.entity_type, EntityType.LOCATION)
85-
# NOTE: As of Sept. 8, 2016, entity2.salience == 0.14427181
86-
self.assertTrue(0.0 < entity2.salience < 0.4)
84+
self.assertGreater(entity2.salience, 0.0)
8785
self.assertEqual(entity2.mentions, [entity2.name])
8886
self.assertEqual(entity2.wikipedia_url,
8987
'http://en.wikipedia.org/wiki/Italy')
9088
self.assertEqual(entity2.metadata, {})
9189
# Verify entity 3.
9290
self.assertEqual(entity3.name, self.NAME3)
9391
self.assertEqual(entity3.entity_type, EntityType.EVENT)
94-
self.assertTrue(0 < entity3.salience < 0.1)
92+
self.assertGreater(entity3.salience, 0.0)
9593
self.assertEqual(entity3.mentions, [entity3.name])
9694
wiki_url = ('http://en.wikipedia.org/wiki/'
9795
'The_Calling_of_St_Matthew_(Caravaggio)')

0 commit comments

Comments
 (0)