Skip to content

Commit 32ea992

Browse files
authored
test: compatibility with proto-plus 1.22.3 (#733)
1 parent aeded22 commit 32ea992

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

packages/google-cloud-firestore/tests/unit/v1/test_cross_language.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import mock
2121
import pytest
2222

23+
import proto as proto_plus
24+
2325
from google.cloud.firestore_v1.types import document
2426
from google.cloud.firestore_v1.types import firestore
2527
from google.cloud.firestore_v1.types import write
@@ -244,7 +246,10 @@ def callback(keys, applied_changes, read_time):
244246
watch = Watch.for_query(query, callback, DocumentSnapshot)
245247

246248
wrapped_responses = [
247-
firestore.ListenResponse.wrap(proto) for proto in testcase.responses
249+
firestore.ListenResponse.wrap(proto._pb)
250+
if isinstance(proto, proto_plus.Message)
251+
else firestore.ListenResponse.wrap(proto)
252+
for proto in testcase.responses
248253
]
249254
if testcase.is_error:
250255
try:
@@ -336,10 +341,15 @@ def convert_set_option(option):
336341
def convert_precondition(precond):
337342
from google.cloud.firestore_v1 import Client
338343

339-
if precond.HasField("exists"):
344+
if isinstance(precond, proto_plus.Message):
345+
precond_pb = precond._pb
346+
else:
347+
precond_pb = precond
348+
349+
if precond_pb.HasField("exists"):
340350
return Client.write_option(exists=precond.exists)
341351

342-
assert precond.HasField("update_time")
352+
assert precond_pb.HasField("update_time")
343353
return Client.write_option(last_update_time=precond.update_time)
344354

345355

0 commit comments

Comments
 (0)