BigQuery: missing return value in LoadJobConfig.from_api_repr and LoadJobConfig Tests (#4727)

* BigQuery: missing return job config

* BigQuery: LoadJobConfig tests

Author: chemelnucfin

bigquery/google/cloud/bigquery/job.py

@@ -674,6 +674,9 @@ def from_api_repr(cls, resource):
         config._properties = copy.deepcopy(resource)
         config.schema = _parse_schema_resource(schema)
         config.skip_leading_rows = _int_or_none(slr)
+        if config.skip_leading_rows is None:
+            del config.skip_leading_rows
+        return config
 
 
 class LoadJob(_AsyncJob):

bigquery/tests/unit/test_job.py

@@ -207,6 +207,41 @@ def _verifyReadonlyResourceProperties(self, job, resource):
             self.assertIsNone(job.user_email)
 
 
+class TestLoadJobConfig(unittest.TestCase, _Base):
+    JOB_TYPE = 'load'
+
+    def _make_resource(self, started=False, ended=False):
+        resource = super(TestLoadJobConfig, self)._make_resource(
+            started, ended)
+        config = resource['configuration']['load']
+        config['sourceUris'] = [self.SOURCE1]
+        config['destinationTable'] = {
+            'projectId': self.PROJECT,
+            'datasetId': self.DS_ID,
+            'tableId': self.TABLE_ID,
+        }
+
+        return resource
+
+    @staticmethod
+    def _get_target_class():
+        from google.cloud.bigquery.job import LoadJobConfig
+        return LoadJobConfig
+
+    def test_schema(self):
+        from google.cloud.bigquery.schema import SchemaField
+        config = self._get_target_class()()
+        full_name = SchemaField('full_name', 'STRING', mode='REQUIRED')
+        age = SchemaField('age', 'INTEGER', mode='REQUIRED')
+        config.schema = [full_name, age]
+        self.assertEqual(config.schema, [full_name, age])
+
+    def test_api_repr(self):
+        resource = self._make_resource()
+        config = self._get_target_class().from_api_repr(resource)
+        self.assertEqual(config.to_api_repr(), resource)
+
+
 class TestLoadJob(unittest.TestCase, _Base):
     JOB_TYPE = 'load'