Skip to content

Commit 8b31842

Browse files
authored
fix(build): revert maven-shade-plugin 3.3.0
Due to a bug in maven shade plugin 3.3.0, compile dependencies got stripped from `google-cloud-nio:shaded`. This bug only affects artifacts where shadedArtifactAttached=true. Related: googleapis/java-bigtable-hbase#3600 Reference: https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-419
1 parent a897e00 commit 8b31842

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

java-storage-nio/google-cloud-nio/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@
104104
<plugin>
105105
<groupId>org.apache.maven.plugins</groupId>
106106
<artifactId>maven-shade-plugin</artifactId>
107-
<version>3.3.0</version>
107+
<!-- MSHADE-419: 3.3.0 Shade plugin causes pom to be created without compile dependencies -->
108+
<version>3.2.4</version>
108109
<configuration>
109110
<shadedArtifactAttached>true</shadedArtifactAttached>
110111
<relocations>

java-storage-nio/owlbot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@
2121
s.move(library)
2222

2323
s.remove_staging_dirs()
24-
java.common_templates(excludes=["README.md", ".kokoro/build.sh"])
24+
java.common_templates(excludes=["README.md", ".kokoro/build.sh", "renovate.json"])

java-storage-nio/renovate.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,12 @@
6767
"^com.fasterxml.jackson.core"
6868
],
6969
"groupName": "jackson dependencies"
70+
},
71+
{
72+
"packagePatterns": [
73+
"^org.apache.maven.plugins:maven-shade-plugin"
74+
],
75+
"allowedVersions": "(,3.3.0),(3.3.0,)"
7076
}
7177
],
7278
"semanticCommits": true,

0 commit comments

Comments
 (0)