fix: to_camel_case to produce lower camel case instead of PascalCase where relevant

Author: yon-mg

gapic/utils/case.py

@@ -56,7 +56,8 @@ def to_camel_case(s: str) -> str:
         s (str): The input string, provided in any sane case system
 
     Returns:
-        str: The string in lower camel case with the first letter unchanged.
+        str: The string in lower camel case.
     '''
-    items = re.split(r'[_-]', s)
-    return items[0].capitalize() + "".join(x.capitalize() for x in items[1:])
+
+    items = re.split(r'[_-]', to_snake_case(s))
+    return items[0].lower() + "".join(x.capitalize() for x in items[1:])

tests/unit/utils/test_case.py

@@ -28,15 +28,15 @@ def test_constant_to_snake():
 
 
 def test_pascal_to_camel():
-    assert case.to_camel_case('PascalCaseThing') == 'PascalCaseThing'
+    assert case.to_camel_case('PascalCaseThing') == 'pascalCaseThing'
 
 
 def test_snake_to_camel():
     assert case.to_camel_case('snake_case_thing') == 'snakeCaseThing'
 
 
 def test_constant_to_camel():
-    assert case.to_camel_case('CONSTANT_CASE_THING') == 'ConstantCaseThing'
+    assert case.to_camel_case('CONSTANT_CASE_THING') == 'constantCaseThing'
 
 
 def test_kebab_to_camel():