Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit c453d28

Browse files
authored
Revert "fix(rest): Use strict encoding to lowercase query string bools (#1436)"
This reverts commit e667406.
1 parent cbe3a9c commit c453d28

6 files changed

Lines changed: 10 additions & 5 deletions

File tree

gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/rest.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ class {{service.name}}RestTransport({{service.name}}Transport):
364364
"{host}{uri}".format(host=self._host, uri=uri),
365365
timeout=timeout,
366366
headers=headers,
367-
params=rest_helpers.flatten_query_params(query_params, strict=True),
367+
params=rest_helpers.flatten_query_params(query_params),
368368
{% if body_spec %}
369369
data=body,
370370
{% endif %}

gapic/ads-templates/setup.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ setuptools.setup(
1919
install_requires=(
2020
{# TODO(dovs): remove when 1.x deprecation is complete #}
2121
{% if 'rest' in opts.transport %}
22-
'google-api-core[grpc] >= 2.10.0, < 3.0.0dev',
22+
'google-api-core[grpc] >= 2.4.0, < 3.0.0dev',
2323
{% else %}
2424
'google-api-core[grpc] >= 1.28.0, < 3.0.0dev',
2525
{% endif %}

gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,7 @@ def test_{{ method_name }}_rest_required_fields(request_type={{ method.input.ide
12161216
{% elif req_field.field_pb.type == 8 %}
12171217
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}).lower(),
12181218
{% else %}
1219-
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}),
1219+
{{ req_field.type.python_type(req_field.field_pb.default_value or 0) }},
12201220
{% endif %}{# default is str #}
12211221
),
12221222
{% endfor %}

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ class {{service.name}}RestTransport({{service.name}}Transport):
398398
"{host}{uri}".format(host=self._host, uri=uri),
399399
timeout=timeout,
400400
headers=headers,
401-
params=rest_helpers.flatten_query_params(query_params, strict=True),
401+
params=rest_helpers.flatten_query_params(query_params),
402402
{% if body_spec %}
403403
data=body,
404404
{% endif %}

gapic/templates/setup.py.j2

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,12 @@ setuptools.setup(
3030
platforms='Posix; MacOS X; Windows',
3131
include_package_data=True,
3232
install_requires=(
33+
{# TODO(dovs): remove when 1.x deprecation is complete #}
34+
{% if 'rest' in opts.transport %}
3335
'google-api-core[grpc] >= 2.10.0, < 3.0.0dev',
36+
{% else %}
37+
'google-api-core[grpc] >= 2.10.0, < 3.0.0dev',
38+
{% endif %}
3439
'libcst >= 0.2.5',
3540
'googleapis-common-protos >= 1.55.0, <2.0.0dev',
3641
'proto-plus >= 1.19.7',

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1105,7 +1105,7 @@ def test_{{ method_name }}_rest_required_fields(request_type={{ method.input.ide
11051105
{% elif req_field.field_pb.type == 8 %}
11061106
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}).lower(),
11071107
{% else %}
1108-
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}),
1108+
{{ req_field.type.python_type(req_field.field_pb.default_value or 0) }},
11091109
{% endif %}{# default is str #}
11101110
),
11111111
{% endfor %}

0 commit comments

Comments
 (0)