Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit 5748001

Browse files
authored
fix: Check for default value presence for non-optional fields in REST (#868)
1 parent 5339db1 commit 5748001

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

  • gapic/templates/%namespace/%name_%version/%sub/services/%service/transports

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,14 +195,15 @@ class {{ service.name }}RestTransport({{ service.name }}Transport):
195195
if {{ method.input.ident }}.{{ field }} in request:
196196
query_params['{{ field|camel_case }}'] = request.{{ field }}
197197
{% else %}
198-
query_params['{{ field|camel_case }}'] = request.{{ field }}
198+
if request.{{ field }}:
199+
query_params['{{ field|camel_case }}'] = request.{{ field }}
199200
{% endif %}
200201
{% endfor %}
201202

202203
# TODO(yon-mg): further discussion needed whether 'python truthiness' is appropriate here
203204
# discards default values
204205
# TODO(yon-mg): add test for proper url encoded strings
205-
query_params = ['{k}={v}'.format(k=k, v=v) for k, v in query_params.items() if v]
206+
query_params = ['{k}={v}'.format(k=k, v=v) for k, v in query_params.items()]
206207
url += '?{}'.format('&'.join(query_params)).replace(' ', '+')
207208

208209
# Send the request

0 commit comments

Comments
 (0)