Fold tool-cache fallback chain into ADR-35802 requirement #1#37970
Closed
Copilot wants to merge 1 commit into
Closed
Fold tool-cache fallback chain into ADR-35802 requirement #1#37970Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Co-authored-by: zarenner <13670625+zarenner@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
zarenner
June 8, 2026 23:30
View session
Collaborator
|
Closing as dup of #37966 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-35802's normative spec resolved the tool cache as
RUNNER_TOOL_CACHE→/opt/hostedtoolcacheunconditionally when unset, so the resolved value was always populated and the standalone/home/runner/work/_toolfallback in requirement #4 was unreachable. This realigns the spec with the implementation's actual resolution order.Changes
RUNNER_TOOL_CACHEwhen set; otherwise/opt/hostedtoolcachewhen it exists; otherwise/home/runner/work/_toolwhen it exists./home/runner/work/_toolclause (old Add workflow: githubnext/agentics/weekly-research #4), folded into the resolution chain.:ro(now Add workflow: githubnext/agentics/weekly-research #4) andGH_AW_TOOL_CACHE_MOUNT(now Add workflow: githubnext/agentics/weekly-research #5) requirements.Documentation-only change. The Part 1 narrative already described this ordering correctly, and the
BuildAWFCommandprobe inpkg/workflow/awf_helpers.goalready implements the chain via itselif -d /home/runner/work/_toolbranch, so no code or golden files change.