Skip to content

Align TestUtil.findCliPath() lookup order with review feedback #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edburns merged 2 commits into from
May 21, 2026
Merged

Align TestUtil.findCliPath() lookup order with review feedback #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3f1bc7
Initial plan
Copilot May 21, 2026
96f9cd7
Align CLI path lookup order and Javadoc in TestUtil
Copilot May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/test/java/com/github/copilot/sdk/TestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ public static String tempPath(String filename) {
* <p>
* Resolution order:
* <ol>
* <li>Search the system PATH using {@code where.exe} (Windows) or {@code which}
* (Linux/macOS).</li>
* <li>Fall back to the {@code COPILOT_CLI_PATH} environment variable.</li>
* <li>Use the {@code COPILOT_CLI_PATH} environment variable when set.</li>
* <li>Otherwise search the system PATH using {@code where.exe} (Windows) or
* {@code which} (Linux/macOS).</li>
* <li>Walk parent directories looking for
* {@code nodejs/node_modules/@github/copilot/index.js}.</li>
* </ol>
Expand All @@ -55,16 +55,16 @@ public static String tempPath(String filename) {
* {@code null} if none was found
*/
static String findCliPath() {
String copilotInPath = findCopilotInPath();
if (copilotInPath != null) {
return copilotInPath;
}

String envPath = System.getenv("COPILOT_CLI_PATH");
if (envPath != null && !envPath.isEmpty()) {
return envPath;
}

String copilotInPath = findCopilotInPath();
if (copilotInPath != null) {
return copilotInPath;
}

Path current = Paths.get(System.getProperty("user.dir"));
while (current != null) {
Path cliPath = current.resolve("nodejs/node_modules/@github/copilot/index.js");
Expand Down
Loading