Narrowly focused implementation of RULE 15-0-1#1121
Open
MichaelRFairhurst wants to merge 20 commits intomainfrom
Open
Narrowly focused implementation of RULE 15-0-1#1121MichaelRFairhurst wants to merge 20 commits intomainfrom
MichaelRFairhurst wants to merge 20 commits intomainfrom
Conversation
MichaelRFairhurst
changed the title
…ub.com:github/codeql-coding-standards into michaelrfairhurst/classes-3-take-2-rule-15-0-1
…ub.com:github/codeql-coding-standards into michaelrfairhurst/classes-3-take-2-rule-15-0-1
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new MISRA C++:2023 RULE-15-0-1 implementation (plus an audit companion query) to detect incorrectly provided special member functions, including packaging/metadata wiring and a dedicated test suite.
Changes:
- Introduces
ImproperlyProvidedSpecialMemberFunctions.qlandImproperlyProvidedSpecialMemberFunctionsAudit.qlfor RULE-15-0-1. - Adds helper library logic (
AnalyzableClass.qll) to model special-member availability/customization. - Registers the new rule package in exclusions/metadata and adds comprehensive
.qlref/.expected/C++ test fixtures.
Show a summary per file
| File | Description |
|---|---|
| rule_packages/cpp/Classes3.json | Adds RULE-15-0-1 rule package entries (main + audit). |
| cpp/misra/src/rules/RULE-15-0-1/ImproperlyProvidedSpecialMemberFunctions.ql | Main RULE-15-0-1 query implementation and message logic. |
| cpp/misra/src/rules/RULE-15-0-1/ImproperlyProvidedSpecialMemberFunctionsAudit.ql | Audit query for “not analyzable” classes. |
| cpp/misra/src/rules/RULE-15-0-1/AnalyzableClass.qll | Shared modeling of special member functions for analyzable classes. |
| cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll | Wires the new Classes3 package into query metadata/exclusions. |
| cpp/common/src/codingstandards/cpp/exclusions/cpp/Classes3.qll | New autogenerated metadata module for the Classes3 package. |
| cpp/misra/test/rules/RULE-15-0-1/test.cpp | New C++ test fixture covering compliant/non-compliant and audit cases. |
| cpp/misra/test/rules/RULE-15-0-1/*.qlref | Test references to the production queries. |
| cpp/misra/test/rules/RULE-15-0-1/*.expected | Expected results for both main and audit queries. |
Copilot's findings
Comments suppressed due to low confidence (4)
cpp/misra/test/rules/RULE-15-0-1/test.cpp:376
- The audit
.expectedfile reports an alert at this class, but the test source does not mark it// NON_COMPLIANT(or similar). Please add the appropriateNON_COMPLIANTannotation here or remove/update the corresponding row inImproperlyProvidedSpecialMemberFunctionsAudit.expected.
class UnmovableDerivedPublicVirtualDtor
: public UnmovableBasePublicVirtualDtor {};
cpp/misra/test/rules/RULE-15-0-1/test.cpp:403
- The audit
.expectedfile reports an alert at this class, but the test source does not mark it// NON_COMPLIANT(or similar). Please add the appropriateNON_COMPLIANTannotation here or remove/update the corresponding row inImproperlyProvidedSpecialMemberFunctionsAudit.expected.
class ProtectedDtorDerived : public BaseProtectedDtor {};
cpp/misra/test/rules/RULE-15-0-1/test.cpp:416
- The audit
.expectedfile reports an alert at this class, but the test source does not mark it// NON_COMPLIANT(or similar). Please add the appropriateNON_COMPLIANTannotation here or remove/update the corresponding row inImproperlyProvidedSpecialMemberFunctionsAudit.expected.
class VirtualProtectedDtorDerived : public BaseVirtualProtectedDtor {};
cpp/misra/test/rules/RULE-15-0-1/test.cpp:390
- The audit
.expectedfile reports an alert at this class, but the test source does not mark it// NON_COMPLIANT(or similar). Please add the appropriateNON_COMPLIANTannotation here or remove/update the corresponding row inImproperlyProvidedSpecialMemberFunctionsAudit.expected.
class UnmovablePrivateVirtualDtorDerived : public UnmovablePrivateVirtualDtor {
};
- Files reviewed: 11/11 changed files
- Comments generated: 9
jeongsoolee09
requested changes
Apr 30, 2026
Collaborator
jeongsoolee09
left a comment
jeongsoolee09
left a comment
There was a problem hiding this comment.
Some thoughts, overall looks amazing!! Thank you so much for tackling this to an already great extent!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
RULE-15-0-1Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.