Node 24 Support (#1357)

Since GitHub will force Node 24 on June 2nd, 2026:
* Update to Node 24 and npm 11
* Update dependencies
* Bump action version to 2

ESlint needs a bump once the GitHub plugin supports v10

Author: dscho

.github/workflows/npm-run-package.yml

@@ -22,9 +22,13 @@ jobs:
           repository: ${{ github.event.repository.full_name }}
           ref: ${{ inputs.branch }}${{ github.event.ref }}
           token: ${{ secrets.GIT_FOR_WINDOWS_CI_PUSH }}
+      - uses: actions/setup-node@v6
+        with:
+          node-version: 24
       - run: npm ci
       - run: npm run build
       - run: npm run lint
+      - run: npm run typecheck
       - run: npm run format && git diff-files
       - run: npm run test
       - run: npm run package
@@ -33,7 +37,7 @@ jobs:
         run: |
           git add -u -- dist/ &&
           git diff-index --cached --exit-code HEAD -- ||
-          echo "::set-output name=need-to-commit::yes"
+          echo "need-to-commit=yes" >> "$GITHUB_OUTPUT"
       - name: commit & push
         if: steps.check.outputs.need-to-commit == 'yes'
         run: |

.github/workflows/test.yml

@@ -13,9 +13,13 @@ jobs:
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
+        with:
+          node-version: 24
       - run: npm ci
       - run: npm run build
       - run: npm run lint
+      - run: npm run typecheck
       - run: npm run format && git diff-files
       - run: npm run test
       - run: npm run package

README.md

@@ -13,7 +13,7 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - name: Setup Git for Windows' minimal SDK
-      uses: git-for-windows/setup-git-for-windows-sdk@v1
+      uses: git-for-windows/setup-git-for-windows-sdk@v2
     - name: Build
       shell: bash
       run: make
@@ -78,7 +78,7 @@ On self-hosted runners, the SDK files persist after the workflow run is done. To
 
 ## Developing _this_ Action
 
-> First, you'll need to have a reasonably modern version of `node` handy, such as Node 12.
+> First, you'll need to have a reasonably modern version of `node` handy, such as Node 24.
 
 Install the dependencies
 
@@ -97,25 +97,12 @@ Run the tests :heavy_check_mark:
 ```bash
 $ npm test
 
-> setup-git-for-windows-sdk@0.0.0 test C:\Users\me\setup-git-for-windows-sdk
-> jest
+ ✓ __tests__/main.test.ts (1)
+   ✓ skipping tests requiring network access
+ ✓ src/__tests__/git.test.ts (2)
+   ✓ git (2)
 
-PASS __tests__/main.test.ts (28.869 s)
-  √ skipping tests requiring network access (224 ms)
-
-  console.log
-    If you want to run tests that access the network, set:
-    export RUN_NETWORK_TESTS=true
-
-      at __tests__/main.test.ts:26:13
-
-PASS __tests__/downloader.test.ts (29.889 s)
-  √ can obtain build ID (9 ms)
-
-Test Suites: 2 passed, 2 total
-Tests:       2 passed, 2 total
-Snapshots:   0 total
-Time:        31.11 s
-Ran all test suites.
+ Test Files  2 passed (2)
+      Tests  3 passed (3)
 ...
 ```

__mocks__/@octokit/rest.js

@@ -1,9 +1,9 @@
-module.exports = {
-    __esModule: true,
-    Octokit: jest.fn().mockImplementation(() => {
+import {vi} from 'vitest'
+
+export const Octokit = vi.fn().mockImplementation(() => {
         return {
             actions: {
-                listWorkflowRuns: jest.fn().mockResolvedValue({
+                listWorkflowRuns: vi.fn().mockResolvedValue({
                     data: {
                         workflow_runs: [
                             {
@@ -12,7 +12,7 @@ module.exports = {
                         ]
                     }
                 }),
-                listWorkflowRunArtifacts: jest.fn().mockResolvedValue({
+                listWorkflowRunArtifacts: vi.fn().mockResolvedValue({
                     data: {
                         artifacts: [
                             {
@@ -23,19 +23,19 @@ module.exports = {
                         ]
                     }
                 }),
-                downloadArtifact: jest.fn().mockResolvedValue({
+                downloadArtifact: vi.fn().mockResolvedValue({
                     data: 'mock artifact content'
                 })
             },
             repos: {
-                getBranch: jest.fn().mockResolvedValue({
+                getBranch: vi.fn().mockResolvedValue({
                     data: {
                         commit: {
                             sha: 'mock_sha'
                         }
                     }
                 }),
-                getReleaseByTag: jest.fn().mockResolvedValue({
+                getReleaseByTag: vi.fn().mockResolvedValue({
                     status: 200,
                     data: {
                         html_url: 'https://github.com/git-for-windows/git-sdk-64/releases/tag/ci-artifacts',
@@ -53,7 +53,7 @@ module.exports = {
                         ]
                     }
                 }),
-                listReleases: jest.fn().mockResolvedValue({
+                listReleases: vi.fn().mockResolvedValue({
                     data: [
                         {
                             tag_name: 'v2.41.0.windows.1',
@@ -69,4 +69,3 @@ module.exports = {
             }
         }
     })
-}

__tests__/main.test.ts

@@ -1,4 +1,5 @@
 /* eslint no-console: "off" */
+import {test, expect} from 'vitest'
 import * as child_process from 'child_process'
 import * as path from 'path'
 import * as process from 'process'
@@ -40,33 +41,35 @@ if (process.env.RUN_NETWORK_TESTS !== 'true') {
     ).toEqual(1)
   })
 
-  jest.setTimeout(5 * 60 * 1000) // this can easily take a minute or five
+  test(
+    'extract the 64-bit minimal SDK',
+    async () => {
+      const outputDirectory = `${__dirname}/../git-sdk-64-minimal`
+      expect(
+        await runAction({
+          env: {
+            INPUT_FLAVOR: 'minimal',
+            INPUT_ARCHITECTURE: 'x86_64',
+            INPUT_PATH: outputDirectory,
+            INPUT_VERBOSE: '250',
+            INPUT_CACHE: 'true'
+          }
+        })
+      ).toEqual(0)
+      expect(
+        statSync.bind(null, `${outputDirectory}/mingw64/bin/gcc.exe`)
+      ).not.toThrow()
 
-  test('extract the 64-bit minimal SDK', async () => {
-    const outputDirectory = `${__dirname}/../git-sdk-64-minimal`
-    expect(
-      await runAction({
-        env: {
-          INPUT_FLAVOR: 'minimal',
-          INPUT_ARCHITECTURE: 'x86_64',
-          INPUT_PATH: outputDirectory,
-          INPUT_VERBOSE: '250',
-          INPUT_CACHE: 'true'
+      const hello = child_process.spawnSync(
+        'usr\\bin\\bash.exe',
+        ['-lc', 'cat <(echo hello)'],
+        {
+          cwd: outputDirectory
         }
-      })
-    ).toEqual(0)
-    expect(
-      statSync.bind(null, `${outputDirectory}/mingw64/bin/gcc.exe`)
-    ).not.toThrow()
-
-    const hello = child_process.spawnSync(
-      'usr\\bin\\bash.exe',
-      ['-lc', 'cat <(echo hello)'],
-      {
-        cwd: outputDirectory
-      }
-    )
-    expect(hello.stderr.toString()).toBe('')
-    expect(hello.stdout.toString()).toBe('hello\n')
-  })
+      )
+      expect(hello.stderr.toString()).toBe('')
+      expect(hello.stdout.toString()).toBe('hello\n')
+    },
+    5 * 60 * 1000
+  )
 }

action.yml

@@ -47,6 +47,6 @@ inputs:
       [Learn more about creating and using encrypted secrets](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets)
     default: ${{ github.token }}
 runs:
-  using: 'node20'
+  using: 'node24'
   main: 'dist/index.js'
   post: 'dist/index.js'