Compiler api harmonise

[7sharp9]

This PR addresses the fact the SimpleSourceCodeServices has compile specific API's that are not present in SourceCodeServices.

The benefits of this PR is that a single FSharpChecker can be created and used to do compile operations, rather than having to move between SimpleSourceCodeServices and SourceCodeServices.

[7sharp9]

Fixes / Implements #516

[dsyme]

Great work. Could you also please deprecate the methods in SimpeServices.fsi? And adjust any documentation (if there is any for these).

[dsyme]

I think these operations should all go via the backgroundCompiler and the Reactor thread - that's more obvious now that they are all part of the proper service API. Could you add that as part of this PR? Or we could do that as a separate item of work.

[7sharp9]

I think a separate PR as that would be a change of functionality, Im not entirely sure on the interaction of the compile action with an ongoing background compilation. Maybe that in itself is a good reason for a reactor lock.

[7sharp9]

Do we need to depreciate the compile methods in SimpleSourceCodeServices?

Maybe SimpleSourceCodeServices should be depreciated entirely? The only reason Ive ever used it was to use the CompileFromAsts method!

[dsyme]

Maybe SimpleSourceCodeServices should be depreciated entirely? The only reason Ive ever used it was to use the CompileFromAsts method!

Yes, I believe it can now be deprecated (though please double check, maybe there's something dangling).

[7sharp9]

Theres quite a few uses around on github, I think the bast bet is to mark it as depreciated for now, I can add that to this PR.

[dsyme]

Theres quite a few uses around on github, I think the bast bet is to mark it as depreciated for now, I can add that to this PR.

Great, thanks

[dsyme]

Here's the AppVeyor failure:

[00:05:40] C:\Program Files\dotnet\dotnet.exe compile-fsc @C:\projects\fsharp-compiler-service\src\fsharp\FSharp.Compiler.Service\obj\Release\netstandard1.6\dotnet-compile.rsp returned Exit Code 1
[00:05:40] C:\projects\fsharp-compiler-service\src\fsharp\vs\service.fs(2189,31): error FS0039: The namespace or module 'AssemblyBuilder' is not defined
[00:05:40] C:\projects\fsharp-compiler-service\src\fsharp\vs\service.fs(2190,29): error FS0072: Lookup on object of indeterminate type based on information prior to this program point. A type annotation may be needed prior to this program point to constrain the type of the object. This may allow the lookup to be resolved.

[7sharp9]

Hmm, dotnetcore issue?

[7sharp9]

At the moment I have to disable dotnetcore to get mono to compile. Maybe #637 needs a closer look to get the CI stable.

[dsyme]

@7sharp9 Yes. Either a missing reference, or changed namespace, or need to #if out the functionality, or something.

[dsyme]

@7sharp9 I think FX_NO_APP_DOMAINS is defined on .NET Core and you may need to open System.Reflection.Emit namespace to find AssemblyBuilder.

[7sharp9]

@dsyme Appveyor is ok now.

[dsyme]

Thanks for this @7sharp9

[7sharp9]

I'll do a further PR later to add the depreciate flag in simplesourcecodeservces and the reactor thread.

[dsyme]

@7sharp9 Thanks. Let's aim to nuke SimpleSourceCodeServices and bring it all into FSharpChecker.