Support PHP 8.1

clue · clue · commit 62d6b801b5d8 · 2021-12-04T11:31:58.000+01:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,6 +11,7 @@ jobs:
     strategy:
       matrix:
         php:
+          - 8.1
           - 8.0
           - 7.4
           - 7.3
diff --git a/composer.json b/composer.json
@@ -9,7 +9,7 @@
         "react/event-loop": "^1.2",
         "react/promise": "^2.7",
         "react/promise-stream": "^1.1",
-        "react/promise-timer": "^1.5",
+        "react/promise-timer": "^1.8",
         "react/socket": "^1.9"
     },
     "require-dev": {
diff --git a/src/Io/LazyConnection.php b/src/Io/LazyConnection.php
@@ -34,7 +34,7 @@ class LazyConnection extends EventEmitter implements ConnectionInterface
     public function __construct(Factory $factory, $uri, LoopInterface $loop)
     {
         $args = [];
-        \parse_str(\parse_url($uri, \PHP_URL_QUERY), $args);
+        \parse_str((string) \parse_url($uri, \PHP_URL_QUERY), $args);
         if (isset($args['idle'])) {
             $this->idlePeriod = (float)$args['idle'];
         }
diff --git a/tests/ResultQueryTest.php b/tests/ResultQueryTest.php
@@ -68,7 +68,7 @@ public function testSelectStaticValueWillBeReturnedAsIs($value)
      */
     public function testSelectStaticValueWillBeReturnedAsIsWithNoBackslashEscapesSqlMode($value)
     {
-        if (strpos($value, '\\') !== false) {
+        if ($value !== null && strpos($value, '\\') !== false) {
             // TODO: strings such as '%\\' work as-is when string contains percent?!
             $this->markTestIncomplete('Escaping backslash not supported when using NO_BACKSLASH_ESCAPES SQL mode');
         }

-Original file line number
+Diff line change
     strategy:
       matrix:
         php:
 +          - 8.1
           - 8.0
           - 7.4
           - 7.3
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ class LazyConnection extends EventEmitter implements ConnectionInterface`
`34`	`34`	`public function __construct(Factory $factory, $uri, LoopInterface $loop)`
`35`	`35`	`{`
`36`	`36`	`$args = [];`
`37`		`- \parse_str(\parse_url($uri, \PHP_URL_QUERY), $args);`
	`37`	`+ \parse_str((string) \parse_url($uri, \PHP_URL_QUERY), $args);`
`38`	`38`	`if (isset($args['idle'])) {`
`39`	`39`	`$this->idlePeriod = (float)$args['idle'];`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public function testSelectStaticValueWillBeReturnedAsIs($value)`
`68`	`68`	`*/`
`69`	`69`	`public function testSelectStaticValueWillBeReturnedAsIsWithNoBackslashEscapesSqlMode($value)`
`70`	`70`	`{`
`71`		`- if (strpos($value, '\\') !== false) {`
	`71`	`+ if ($value !== null && strpos($value, '\\') !== false) {`
`72`	`72`	`// TODO: strings such as '%\\' work as-is when string contains percent?!`
`73`	`73`	`$this->markTestIncomplete('Escaping backslash not supported when using NO_BACKSLASH_ESCAPES SQL mode');`
`74`	`74`	`}`