fix(terminal): safer way of entering terminal mode from scrollback buffer

[qw457812]

Description

After latest commits, the #103 issue is coming back. Nvim exit when I press i in scrollback with tmux.

Related Issue(s)

#103

Screenshots

Exactly the same as #103 's gif.

[folke]

Isn't it enough to just vim.schedule the close?

[qw457812]

I have tried that, it enter term mode then enter normal mode very quick (self:update() triggered twice), like second gif in #103 but quicker, I even can't see the green color of the term mode in lualine, just see the cursor moved (kitty cursor trail).
And without vim.cmd.startinsert(), I need to press i twice to enter term mode: after first i nvim still in normal mode, second i enter term mode.

[folke]

ty!

[qw457812]

@folke Sorry for the pining, just found that following patch works for me too and the purpose is slightly clearer. Not sure if you want (me) to update. Just ignore this message if you feel it is not necessary :)

diff --git a/lua/sidekick/cli/scrollback.lua b/lua/sidekick/cli/scrollback.lua
index 0ce857e..68ac5ba 100644
--- a/lua/sidekick/cli/scrollback.lua
+++ b/lua/sidekick/cli/scrollback.lua
@@ -130,8 +130,8 @@ function M:update(opts)
   if mode == "t" and (self:is_focused() or self:in_terminal()) and is_open then
     vim.cmd.stopinsert()
     vim.schedule(function()
-      self:close()
       vim.cmd.startinsert()
+      self:close()
     end)
   elseif mode ~= "t" and not is_open then
     self:open(opts.win_pos)