Check renderer#1063
Open
grbagwe wants to merge 5 commits into
Open
Conversation
grbagwe
requested review from
AboudyKreidieh,
eugenevinitsky and
kjang96
as code owners
| # check whether we should be rendering | ||
| self.should_render = self.sim_params.render | ||
| self.sim_params.render = False | ||
| self.sim_params.render = self.sim_params.render |
Author
|
Sorry, I am new and I couldn't figure out another way to use the rendered
images to train a CNN network. Therefore I was thinking of something like
this. Also in line 436 self.sim_params.render = True,Sets to true which
prevents it from rendering pyglet. Am I doing something wrong here?
Gaurav Bagwe,
…On Thu, May 5, 2022 at 12:37 PM Eugene Vinitsky ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In flow/envs/base.py
<#1063 (comment)>:
> @@ -133,7 +133,7 @@ def __init__(self,
self.sim_params = deepcopy(sim_params)
# check whether we should be rendering
self.should_render = self.sim_params.render
- self.sim_params.render = False
+ self.sim_params.render = self.sim_params.render
this seems unnecessary?
—
Reply to this email directly, view it on GitHub
<#1063 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKEHHSQQLJV5KRQLD73V6CTVIP2OJANCNFSM5VFSN2QQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Oh no worries and thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request information
Status: ? (ready to merge / in development)
Kind of changes: ? (bug fix / new feature / documentation...)
Change file in the flow.envs.base to create pyglet rendering.
There was a bug I guess which didn't start the pyglet rendering where the should_render was preventing it from rendering.
Related PR or issue: ? (optional)
Description
? (general description)