Add tests for large_file_threshold

Author: YuriiMotov

tests/test_cli_deploy.py

@@ -2194,3 +2194,128 @@ def test_ctrl_c_during_build_streaming_shows_cancelled(
 
         assert "🟡" in result.output
         assert "Cancelled." in result.output
+
+
+def _create_file(path: Path, size_bytes: int) -> None:
+    """Create a file of the given size."""
+    path.parent.mkdir(parents=True, exist_ok=True)
+    with open(path, "wb") as f:
+        if size_bytes > 0:
+            f.seek(size_bytes - 1)
+            f.write(b"\0")
+
+
+@pytest.mark.respx
+def test_large_file_threshold_warning(
+    logged_in_cli: None, tmp_path: Path, respx_mock: respx.MockRouter
+) -> None:
+    app_data = _get_random_app()
+    app_id = app_data["id"]
+    team_id = "some-team-id"
+    deployment_data = _get_random_deployment(app_id=app_id)
+
+    _setup_deployment_mocks(
+        respx_mock, app_id, team_id, deployment_data, tmp_path
+    )
+    respx_mock.get(f"/apps/{app_id}/deployments/{deployment_data['id']}").mock(
+        return_value=Response(200, json={**deployment_data, "status": "success"})
+    )
+
+    _create_file(tmp_path / "model.bin", 12 * 1024 * 1024)  # 12 MB
+    _create_file(tmp_path / "data.csv", 11 * 1024 * 1024)  # 11 MB
+
+    with changing_dir(tmp_path):
+        result = runner.invoke(app, ["deploy"])
+
+    assert result.exit_code == 0
+    assert "Some uploaded files are larger than 10 MB" in result.output
+    assert "model.bin" in result.output
+    assert "12 MB" in result.output
+    assert "data.csv" in result.output
+    assert "11 MB" in result.output
+
+
+@pytest.mark.respx
+def test_large_file_threshold_only_top_three_files_with_more_indicator(
+    logged_in_cli: None, tmp_path: Path, respx_mock: respx.MockRouter
+) -> None:
+    app_data = _get_random_app()
+    app_id = app_data["id"]
+    team_id = "some-team-id"
+    deployment_data = _get_random_deployment(app_id=app_id)
+
+    _setup_deployment_mocks(
+        respx_mock, app_id, team_id, deployment_data, tmp_path
+    )
+    respx_mock.get(f"/apps/{app_id}/deployments/{deployment_data['id']}").mock(
+        return_value=Response(200, json={**deployment_data, "status": "success"})
+    )
+
+    _create_file(tmp_path / "huge.bin", 50 * 1024 * 1024)
+    _create_file(tmp_path / "big.bin", 40 * 1024 * 1024)
+    _create_file(tmp_path / "medium.bin", 30 * 1024 * 1024)
+    _create_file(tmp_path / "smaller.bin", 20 * 1024 * 1024)
+    _create_file(tmp_path / "smallest.bin", 15 * 1024 * 1024)
+
+    with changing_dir(tmp_path):
+        result = runner.invoke(app, ["deploy"])
+
+    assert result.exit_code == 0
+    assert "huge.bin" in result.output
+    assert "big.bin" in result.output
+    assert "medium.bin" in result.output
+    assert "smaller.bin" not in result.output
+    assert "smallest.bin" not in result.output
+    assert "...and 2 more" in result.output
+
+
+@pytest.mark.respx
+def test_large_file_threshold_does_not_warn_when_no_large_files(
+    logged_in_cli: None, tmp_path: Path, respx_mock: respx.MockRouter
+) -> None:
+    app_data = _get_random_app()
+    app_id = app_data["id"]
+    team_id = "some-team-id"
+    deployment_data = _get_random_deployment(app_id=app_id)
+
+    _setup_deployment_mocks(
+        respx_mock, app_id, team_id, deployment_data, tmp_path
+    )
+    respx_mock.get(f"/apps/{app_id}/deployments/{deployment_data['id']}").mock(
+        return_value=Response(200, json={**deployment_data, "status": "success"})
+    )
+
+    (tmp_path / "main.py").write_text("print('hello')")
+
+    with changing_dir(tmp_path):
+        result = runner.invoke(app, ["deploy"])
+
+    assert result.exit_code == 0
+    assert "Some uploaded files are larger than" not in result.output
+
+
+@pytest.mark.respx
+def test_large_file_threshold_custom_threshold(
+    logged_in_cli: None, tmp_path: Path, respx_mock: respx.MockRouter
+) -> None:
+    app_data = _get_random_app()
+    app_id = app_data["id"]
+    team_id = "some-team-id"
+    deployment_data = _get_random_deployment(app_id=app_id)
+
+    _setup_deployment_mocks(
+        respx_mock, app_id, team_id, deployment_data, tmp_path
+    )
+    respx_mock.get(f"/apps/{app_id}/deployments/{deployment_data['id']}").mock(
+        return_value=Response(200, json={**deployment_data, "status": "success"})
+    )
+
+    # 5 MB file: above a 1 MB threshold, below the default 10 MB threshold
+    _create_file(tmp_path / "data.bin", 5 * 1024 * 1024)
+
+    with changing_dir(tmp_path):
+        result = runner.invoke(app, ["deploy", "--large-file-threshold", "1"])
+
+    assert result.exit_code == 0
+    assert "Some uploaded files are larger than 1 MB" in result.output
+    assert "data.bin" in result.output

tests/test_deploy_utils.py

@@ -3,12 +3,21 @@
 import pytest
 
 from fastapi_cloud_cli.commands.deploy import (
+    _get_large_files,
     _should_exclude_entry,
     validate_app_directory,
 )
 from fastapi_cloud_cli.utils.api import DeploymentStatus
 
 
+def _create_file(path: Path, size_bytes: int) -> None:
+    path.parent.mkdir(parents=True, exist_ok=True)
+    with open(path, "wb") as f:
+        if size_bytes > 0:
+            f.seek(size_bytes - 1)
+            f.write(b"\0")
+
+
 @pytest.mark.parametrize(
     "path",
     [
@@ -135,3 +144,48 @@ def test_validate_app_directory_invalid(value: str, expected_message: str) -> No
         validate_app_directory(value)
 
     assert str(exc_info.value) == expected_message
+
+
+def test_get_large_files_no_files_above_threshold(tmp_path: Path) -> None:
+    """Should not return files smaller than the threshold."""
+    _create_file(tmp_path / "small.bin", 512 * 1024)  # 0.5 MB
+
+    assert _get_large_files(tmp_path, threshold_mb=1) == []
+
+
+def test_get_large_files_returns_files_at_or_above_threshold(tmp_path: Path) -> None:
+    """Should return files at or above the threshold with sizes and relative paths."""
+    _create_file(tmp_path / "big.bin", 2 * 1024 * 1024)  # 2 MB
+    _create_file(tmp_path / "subdir" / "huge.bin", 5 * 1024 * 1024)  # 5 MB
+    _create_file(tmp_path / "small.bin", 100 * 1024)  # 0.1 MB
+
+    result = _get_large_files(tmp_path, threshold_mb=1)
+
+    assert sorted(result, key=lambda x: x[1]) == [
+        (Path("big.bin"), 2 * 1024 * 1024),
+        (Path("subdir") / "huge.bin", 5 * 1024 * 1024),
+    ]
+
+
+def test_get_large_files_excludes_default_exclusions(tmp_path: Path) -> None:
+    """Should not count files in excluded directories like .venv or __pycache__."""
+    _create_file(tmp_path / ".venv" / "lib" / "huge.so", 5 * 1024 * 1024)
+    _create_file(
+        tmp_path / "__pycache__" / "module.cpython-311.pyc", 5 * 1024 * 1024
+    )
+    _create_file(tmp_path / "main.py", 5 * 1024 * 1024)
+
+    assert _get_large_files(tmp_path, threshold_mb=1) == [
+        (Path("main.py"), 5 * 1024 * 1024)
+    ]
+
+
+def test_get_large_files_respects_fastapicloudignore(tmp_path: Path) -> None:
+    """Should not count files matching .fastapicloudignore patterns."""
+    _create_file(tmp_path / "data" / "huge.bin", 5 * 1024 * 1024)
+    _create_file(tmp_path / "main.bin", 5 * 1024 * 1024)
+    (tmp_path / ".fastapicloudignore").write_text("data/\n")
+
+    assert _get_large_files(tmp_path, threshold_mb=1) == [
+        (Path("main.bin"), 5 * 1024 * 1024)
+    ]