Skip to content

Commit fccf3a9

Browse files
Remove redundant test steps (#26161)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary This TODO mentions an issue with JSDOM that [seems to have been resolved](jsdom/jsdom#2996). <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## How did you test this change? - Ensured that the `document.activeElement` is no longer `node` after `node.blur` is called. - Verified that the tests still pass. - Looked for [a merged PR that fixes the issue](jsdom/jsdom#2996). <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
1 parent 86c8c8d commit fccf3a9

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

packages/react-dom/src/__tests__/ReactDOMInput-test.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1880,13 +1880,7 @@ describe('ReactDOMInput', () => {
18801880
node.focus();
18811881
setUntrackedValue.call(node, '2');
18821882
dispatchEventOnNode(node, 'input');
1883-
// TODO: it is unclear why blur must be triggered twice,
1884-
// manual testing in the fixtures shows that the active element
1885-
// is no longer the input, however blur() + a blur event seem to
1886-
// be the only way to remove focus in JSDOM
18871883
node.blur();
1888-
dispatchEventOnNode(node, 'blur');
1889-
dispatchEventOnNode(node, 'focusout');
18901884

18911885
if (disableInputAttributeSyncing) {
18921886
expect(node.value).toBe('2');
@@ -1906,13 +1900,7 @@ describe('ReactDOMInput', () => {
19061900
node.focus();
19071901
setUntrackedValue.call(node, 4);
19081902
dispatchEventOnNode(node, 'input');
1909-
// TODO: it is unclear why blur must be triggered twice,
1910-
// manual testing in the fixtures shows that the active element
1911-
// is no longer the input, however blur() + a blur event seem to
1912-
// be the only way to remove focus in JSDOM
19131903
node.blur();
1914-
dispatchEventOnNode(node, 'blur');
1915-
dispatchEventOnNode(node, 'focusout');
19161904

19171905
expect(node.getAttribute('value')).toBe('1');
19181906
});
@@ -1926,13 +1914,7 @@ describe('ReactDOMInput', () => {
19261914
node.focus();
19271915
setUntrackedValue.call(node, 4);
19281916
dispatchEventOnNode(node, 'input');
1929-
// TODO: it is unclear why blur must be triggered twice,
1930-
// manual testing in the fixtures shows that the active element
1931-
// is no longer the input, however blur() + a blur event seem to
1932-
// be the only way to remove focus in JSDOM
19331917
node.blur();
1934-
dispatchEventOnNode(node, 'blur');
1935-
dispatchEventOnNode(node, 'focusout');
19361918

19371919
expect(node.getAttribute('value')).toBe('1');
19381920
});

0 commit comments

Comments
 (0)