adding support for api gateway's new http apis#94
Merged
jordaneremieff merged 5 commits intoKludex:masterfrom Apr 14, 2020
E-G-C:master
Merged
adding support for api gateway's new http apis#94jordaneremieff merged 5 commits intoKludex:masterfrom E-G-C:master
jordaneremieff merged 5 commits intoKludex:masterfrom
E-G-C:master
Conversation
jordaneremieff
requested changes
Apr 12, 2020
Collaborator
There was a problem hiding this comment.
Looks good, thanks!
I have made a few comments in the review to resolve, but otherwise it should be fine to merge.
Also, if you could add a test that would be helpful, otherwise feel free to add a # pragma: no cover comment to the line causing the coverage script to fail in the build (https://github.com/erm/mangum/pull/94/files#diff-12d2884e46108e48b62f0482aa6988d3R103), and once the build is passing I can follow-up with a test before the next release.
added 4 commits
April 13, 2020 21:43
jordaneremieff
approved these changes
Apr 14, 2020
Collaborator
|
Great work @E-G-C, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed changes in this pull request brings initial support for the new HTTP API .
The event dictionary passed to lambda from the new HTTP API is different from the one expected from the traditional REST API therefore mangum fails in looking up some of the expected keys.