Fix PR4 review findings: skills install compat, dead code, yellow warning

- Always call SetArgs in skills install backward-compat alias (fixes
  Execute path inheriting parent args)
- Add cobra.MaximumNArgs(1) to reject extra positional args
- Remove dead installer.ListSkills function (replaced by list command)
- Restore yellow color for "No agents detected" warning in install.go
- Add Execute-path tests for skills install alias

Co-authored-by: Isaac

Author: simonfaltum

experimental/aitools/cmd/install.go

@@ -9,6 +9,7 @@ import (
 	"github.com/databricks/cli/experimental/aitools/lib/agents"
 	"github.com/databricks/cli/experimental/aitools/lib/installer"
 	"github.com/databricks/cli/libs/cmdio"
+	"github.com/fatih/color"
 	"github.com/spf13/cobra"
 )
 
@@ -111,7 +112,7 @@ func resolveAgentNames(ctx context.Context, names string) ([]*agents.Agent, erro
 
 // printNoAgentsMessage prints the "no agents detected" message.
 func printNoAgentsMessage(ctx context.Context) {
-	cmdio.LogString(ctx, "No supported coding agents detected.")
+	cmdio.LogString(ctx, color.YellowString("No supported coding agents detected."))
 	cmdio.LogString(ctx, "")
 	cmdio.LogString(ctx, "Supported agents: Claude Code, Cursor, Codex CLI, OpenCode, GitHub Copilot, Antigravity")
 	cmdio.LogString(ctx, "Please install at least one coding agent first.")

experimental/aitools/cmd/install_test.go

@@ -278,6 +278,52 @@ func TestSkillsInstallForwardsSkillName(t *testing.T) {
 	assert.Equal(t, []string{"databricks"}, (*calls)[0].opts.SpecificSkills)
 }
 
+func TestSkillsInstallExecuteNoArgs(t *testing.T) {
+	setupTestAgents(t)
+	calls := setupInstallMock(t)
+
+	ctx := cmdio.MockDiscard(t.Context())
+	cmd := newSkillsInstallCmd()
+	cmd.SetContext(ctx)
+	cmd.SetArgs([]string{})
+
+	err := cmd.Execute()
+	require.NoError(t, err)
+
+	require.Len(t, *calls, 1)
+	assert.Len(t, (*calls)[0].agents, 2)
+	assert.Nil(t, (*calls)[0].opts.SpecificSkills)
+}
+
+func TestSkillsInstallExecuteWithSkillName(t *testing.T) {
+	setupTestAgents(t)
+	calls := setupInstallMock(t)
+
+	ctx := cmdio.MockDiscard(t.Context())
+	cmd := newSkillsInstallCmd()
+	cmd.SetContext(ctx)
+	cmd.SetArgs([]string{"databricks"})
+
+	err := cmd.Execute()
+	require.NoError(t, err)
+
+	require.Len(t, *calls, 1)
+	assert.Equal(t, []string{"databricks"}, (*calls)[0].opts.SpecificSkills)
+}
+
+func TestSkillsInstallExecuteRejectsTwoArgs(t *testing.T) {
+	ctx := cmdio.MockDiscard(t.Context())
+	cmd := newSkillsInstallCmd()
+	cmd.SetContext(ctx)
+	cmd.SetArgs([]string{"a", "b"})
+	cmd.SilenceErrors = true
+	cmd.SilenceUsage = true
+
+	err := cmd.Execute()
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "accepts at most 1 arg")
+}
+
 func TestResolveAgentNamesValid(t *testing.T) {
 	ctx := t.Context()
 	result, err := resolveAgentNames(ctx, "claude-code,cursor")

experimental/aitools/cmd/skills.go

@@ -75,13 +75,16 @@ func newSkillsInstallCmd() *cobra.Command {
 	return &cobra.Command{
 		Use:   "install [skill-name]",
 		Short: "Install Databricks skills for detected coding agents",
+		Args:  cobra.MaximumNArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			// Delegate to the flat install command's logic.
 			installCmd := newInstallCmd()
 			installCmd.SetContext(cmd.Context())
 			if len(args) > 0 {
 				// Pass the skill name as a --skills flag.
 				installCmd.SetArgs([]string{"--skills", args[0]})
+			} else {
+				installCmd.SetArgs([]string{})
 			}
 			return installCmd.Execute()
 		},

experimental/aitools/lib/installer/installer.go

@@ -92,26 +92,6 @@ func fetchSkillFile(ctx context.Context, ref, skillName, filePath string) ([]byt
 	return io.ReadAll(resp.Body)
 }
 
-// ListSkills fetches and prints available skills.
-func ListSkills(ctx context.Context) error {
-	manifest, err := FetchManifest(ctx)
-	if err != nil {
-		return err
-	}
-
-	cmdio.LogString(ctx, "Available skills:")
-	cmdio.LogString(ctx, "")
-
-	for name, meta := range manifest.Skills {
-		cmdio.LogString(ctx, fmt.Sprintf("  %s (v%s)", name, meta.Version))
-	}
-
-	cmdio.LogString(ctx, "")
-	cmdio.LogString(ctx, "Install all with: databricks experimental aitools skills install")
-	cmdio.LogString(ctx, "Install one with: databricks experimental aitools skills install <skill-name>")
-	return nil
-}
-
 // InstallSkillsForAgents fetches the manifest and installs skills for the given agents.
 // This is the core installation function. Callers are responsible for agent detection,
 // prompting, and printing the "Installing..." header.