fix: renames zone_id to zone_config_id in Record model (#11)

The implementation used zone_id as provided in the official documentation. However, zone_config_id is the correct field that is sent by the API to the client and must be parsed instead.

Author: becelot

hostingde/model/record.py

@@ -41,7 +41,7 @@ class Record(Model):
     """The DNS Record object is part of a zone. It is used to manage DNS resource records."""
 
     id: Optional[str]
-    zone_id: Optional[str]
+    zone_config_id: Optional[str]
     record_template_id: Optional[str]
     name: Optional[str]
     content: Optional[str]
@@ -54,7 +54,7 @@ class Record(Model):
     def __init__(
         self,
         id: Optional[str] = None,
-        zone_id: Optional[str] = None,
+        zone_config_id: Optional[str] = None,
         record_template_id: Optional[str] = None,
         name: Optional[str] = None,
         type: Optional[RecordType] = None,
@@ -71,7 +71,7 @@ def __init__(
         :param id:                 Record ID. Ignored in create zone requzone_config.pyests. Either id or zoneId, name,
                                    type, and content are required in all other requests.
 
-        :param zone_id:            ID of zone that the record belongs to.
+        :param zone_config_id:            ID of zone that the record belongs to.
 
         :param record_template_id: ID of record template the record is tied to. If empty, record has to be managed
                                    manually. If tied to record template, record will be removed or updated whenever
@@ -101,7 +101,7 @@ def __init__(
         """
         super().__init__(**kwargs)
         self.id = id
-        self.zone_id = zone_id
+        self.zone_config_id = zone_config_id
         self.record_template_id = record_template_id
         self.name = name
         self.type = type

tests/unit/model/test_record.py

@@ -32,7 +32,7 @@ def test_record_constructor():
 def test_parse_record():
     data = dict(
         id='234987fds',
-        zoneId="wegsefgio345235",
+        zoneConfigId="wegsefgio345235",
         recordTemplateId="templateid",
         name="recordname",
         type="A",
@@ -45,7 +45,7 @@ def test_parse_record():
     record = Record.from_json(data)
 
     assert record.id == '234987fds'
-    assert record.zone_id == "wegsefgio345235"
+    assert record.zone_config_id == "wegsefgio345235"
     assert record.record_template_id == "templateid"
     assert record.name == "recordname"
     assert record.type == RecordType.A
@@ -58,7 +58,7 @@ def test_parse_record():
 def test_dump_record():
     record = Record(
         id='234987fds',
-        zone_id="wegsefgio345235",
+        zone_config_id="wegsefgio345235",
         record_template_id="templateid",
         name="recordname",
         type=RecordType.A,
@@ -70,7 +70,7 @@ def test_dump_record():
 
     assert record.to_json() == dict(
         id='234987fds',
-        zoneId="wegsefgio345235",
+        zoneConfigId="wegsefgio345235",
         recordTemplateId="templateid",
         name="recordname",
         type="A",
@@ -91,6 +91,6 @@ def test_create_new_record():
     assert record.ttl == 86400
     assert record.priority is None
 
-    assert record.zone_id is None
+    assert record.zone_config_id is None
     assert record.record_template_id is None
     assert record.last_change_date is None