refactor: add structured logging, fix error handling, and validate inputs#63
Merged
Merged
Conversation
…puts - Add hashprep/utils/logging.py with package-level structured logger - Replace 8 bare `except Exception` blocks with specific exception types (ValueError, LinAlgError, RuntimeWarning, OSError) and debug logging - Add input validation in DatasetAnalyzer.__init__: - TypeError if input is not a DataFrame - ValueError for duplicate column names - ValueError if target_col not found in DataFrame - TypeError if comparison_df is not a DataFrame - Add input validation in check_drift() for both DataFrames
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hashprep/utils/logging.pywith structured logging infrastructure (NullHandler pattern for library best practice)except Exceptionblocks with specific exception types (ValueError,LinAlgError,RuntimeWarning,OSError) across checks and summariesDatasetAnalyzer.__init__(type checks, duplicate columns, target column existence) andcheck_drift()Test plan
logging.basicConfig()is configured by consumer