fix: ts_project fail if root_dir used deep in source tree (#3535)

Author: vpanta

nodejs/private/ts_lib.bzl

@@ -169,7 +169,7 @@ def _out_paths(srcs, out_dir, root_dir, allow_js, ext_map):
     outs = []
     for f in srcs:
         if _is_ts_src(f, allow_js):
-            out = _join(out_dir, f[:f.rindex(".")].replace(rootdir_replace_pattern, "") + _replace_ext(f, ext_map))
+            out = _join(out_dir, f[:f.rindex(".")].replace(rootdir_replace_pattern, "", 1) + _replace_ext(f, ext_map))
 
             # Don't declare outputs that collide with inputs
             # for example, a.js -> a.js

packages/typescript/test/ts_project/rootdir_with_value/BUILD.bazel

@@ -5,6 +5,7 @@ load("//packages/typescript:index.bzl", "ts_project")
 SRCS = [
     "subdir/a.ts",
     "subdir/file.json",
+    "subdir/deep/subdir/b.ts",
 ]
 
 ts_project(

packages/typescript/test/ts_project/rootdir_with_value/subdir/deep/subdir/b.ts

@@ -0,0 +1 @@
+export const a: string = 'so many folders...';

packages/typescript/test/ts_project/rootdir_with_value/verify.js

@@ -2,3 +2,7 @@ const assert = require('assert');
 
 const files = process.argv.slice(2);
 assert.ok(files.some(f => f.endsWith('rootdir_with_value/a.js')), 'Missing a.js');
+
+// Test that the only the top-level matching "rootdir" is removed.
+// NOTE: This should never fail directly, as the bug being fixed is a build-time error.
+assert.ok(files.some(f => f.endsWith('rootdir_with_value/deep/subdir/b.js')), 'Missing b.js');