Skip to content

Commit 6d519eb

Browse files
authored
fix(docs): stray text in npm_install docs (#3450)
"symlink_node_modules is True" doesn't make any sense in this position. I think it was a stray copy and paste from the beginning of the paragraph.
1 parent d234328 commit 6d519eb

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

docs/Built-ins.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -549,8 +549,7 @@ Defaults to `[]`
549549
If symlink_node_modules is True, this attribute is optional since the package manager
550550
will run in your workspace folder. It is recommended, however, that all files that the
551551
package manager depends on, such as `.rc` files or files used in `postinstall`, are added
552-
symlink_node_modules is True so that the repository rule is rerun when any of these files
553-
change.
552+
so that the repository rule is rerun when any of these files change.
554553

555554
If symlink_node_modules is False, the package manager is run in the bazel external
556555
repository so all files that the package manager depends on must be listed.
@@ -1214,8 +1213,7 @@ Defaults to `[]`
12141213
If symlink_node_modules is True, this attribute is optional since the package manager
12151214
will run in your workspace folder. It is recommended, however, that all files that the
12161215
package manager depends on, such as `.rc` files or files used in `postinstall`, are added
1217-
symlink_node_modules is True so that the repository rule is rerun when any of these files
1218-
change.
1216+
so that the repository rule is rerun when any of these files change.
12191217

12201218
If symlink_node_modules is False, the package manager is run in the bazel external
12211219
repository so all files that the package manager depends on must be listed.

internal/npm_install/npm_install.bzl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ COMMON_ATTRIBUTES = dict(dict(), **{
3434
If symlink_node_modules is True, this attribute is optional since the package manager
3535
will run in your workspace folder. It is recommended, however, that all files that the
3636
package manager depends on, such as `.rc` files or files used in `postinstall`, are added
37-
symlink_node_modules is True so that the repository rule is rerun when any of these files
38-
change.
37+
so that the repository rule is rerun when any of these files change.
3938
4039
If symlink_node_modules is False, the package manager is run in the bazel external
4140
repository so all files that the package manager depends on must be listed.

0 commit comments

Comments
 (0)