Skip to content

feat(builtin): expand make vars in nodejs_binary/test env attr#3456

Merged
alexeagle merged 1 commit into
stablefrom
node-expand-make-vars
May 17, 2022
Merged

feat(builtin): expand make vars in nodejs_binary/test env attr#3456
alexeagle merged 1 commit into
stablefrom
node-expand-make-vars

Conversation

@kormide

@kormide kormide commented May 16, 2022

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

nodejs_binary/nodejs_test does not perform make variable substitution.

What is the new behavior?

nodejs_binary/nodejs_test now performs make variable substitution.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The motivating use case is to pass a browser toolchain to an architect_test rule. The path to the browser and driver binaries are provided via a make variable which protractor references.

@kormide kormide force-pushed the node-expand-make-vars branch from 60fb40c to c4b92bb Compare May 16, 2022 21:42
@kormide kormide changed the title feat(builtin): expand make vars in nodejs_binary/test feat(builtin): expand make vars in nodejs_binary/test env attr May 16, 2022
@alexeagle alexeagle merged commit 353593c into stable May 17, 2022
@kormide kormide deleted the node-expand-make-vars branch May 17, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants