feat(builtin): expand make vars in nodejs_binary/test env attr#3456
Merged
Conversation
60fb40c to
c4b92bb
Compare
c4b92bb to
f5ec14e
Compare
14 tasks
alexeagle
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
nodejs_binary/nodejs_testdoes not perform make variable substitution.What is the new behavior?
nodejs_binary/nodejs_testnow performs make variable substitution.Does this PR introduce a breaking change?
Other information
The motivating use case is to pass a browser toolchain to an
architect_testrule. The path to the browser and driver binaries are provided via a make variable which protractor references.