feat(DynamoDbEncryption): Add GetEncryptedDataKeyDescription operation#856
Merged
rishav-karanjit merged 74 commits intomainfrom May 10, 2024
Merged
feat(DynamoDbEncryption): Add GetEncryptedDataKeyDescription operation#856rishav-karanjit merged 74 commits intomainfrom
rishav-karanjit merged 74 commits intomainfrom
Conversation
rishav-karanjit
changed the title
This reverts commit 447630d.
…-sdk-dynamodb into rishav-feat-parser
ajewellamz
reviewed
Apr 11, 2024
ajewellamz
previously approved these changes
Apr 11, 2024
Contributor
ajewellamz
left a comment
ajewellamz
left a comment
There was a problem hiding this comment.
Looks good to me. You probably want someone else's opinion.
kessplas
reviewed
Apr 17, 2024
texastony
suggested changes
May 1, 2024
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
Blocking on a lack of User Documentation (@JavaDoc in the Smithy Model).
Though... I hope we can improve the plaintextItem name...
Comment on lines
+7
to
+9
| public void TestGetEncryptedDataKeyDescription() { | ||
| GetEncryptedDataKeyDescriptionExample.getEncryptedDataKeyDescription(TestUtils.TEST_DDB_TABLE_NAME,"partition_key","BasicPutGetExample","sort_key","0","aws-kms",TestUtils.TEST_KMS_KEY_ID,null,null); | ||
| } |
Contributor
There was a problem hiding this comment.
Refactor this to:
- Only pass
TestUtils.TEST_DDB_TABLE_NAME,"partition_key","BasicPutGetExample" - Have
getEncryptedDataKeyDescriptionreturnEncryptedDataKeyDescription, which the methods name implies with get. - Move all the assertions from the Example to this test.
rishav-karanjit
changed the title
texastony
suggested changes
May 9, 2024
texastony
approved these changes
May 10, 2024
rishav-karanjit
pushed a commit
that referenced
this pull request
May 30, 2024
## [3.5.0](v3.4.0...v3.5.0) (2024-05-30) ### Features * **DynamoDbEncryption:** Add GetEncryptedDataKeyDescription operation ([#856](#856)) ([8f8471a](8f8471a)) * improve verification ([#1020](#1020)) ([cbde4ef](cbde4ef)) * simplify structured encryption ([#866](#866)) ([a70a569](a70a569)) ### Maintenance * allow Legacy to use subclass of DynamoDBEncryptor ([#1073](#1073)) ([135acd9](135acd9)) * bump MPL to 1.4 ([#1067](#1067)) ([51bbab5](51bbab5)) * **Java-Release:** update release commands and use SNAPSHOT builds ([#995](#995)) ([ac9b79e](ac9b79e)) * reformat and enforce formatting ([#1035](#1035)) ([8a76a9d](8a76a9d)) * verify with Dafny 4.6 ([#1072](#1072)) ([9db6e78](9db6e78))
Merged
ajewellamz
pushed a commit
that referenced
this pull request
May 31, 2024
* chore(release): 3.5.0 ## [3.5.0](v3.4.0...v3.5.0) (2024-05-30) ### Features * **DynamoDbEncryption:** Add GetEncryptedDataKeyDescription operation ([#856](#856)) ([8f8471a](8f8471a)) * improve verification ([#1020](#1020)) ([cbde4ef](cbde4ef)) * simplify structured encryption ([#866](#866)) ([a70a569](a70a569)) ### Maintenance * allow Legacy to use subclass of DynamoDBEncryptor ([#1073](#1073)) ([135acd9](135acd9)) * bump MPL to 1.4 ([#1067](#1067)) ([51bbab5](51bbab5)) * **Java-Release:** update release commands and use SNAPSHOT builds ([#995](#995)) ([ac9b79e](ac9b79e)) * reformat and enforce formatting ([#1035](#1035)) ([8a76a9d](8a76a9d)) * verify with Dafny 4.6 ([#1072](#1072)) ([9db6e78](9db6e78))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds GetEncryptedDataKeyDescription to DynamoDbEncryption.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.