feat: Default dimensions from powertools instead of emf library #317
Merged
pankajagrawal16 merged 5 commits intomasterfrom Mar 10, 2021
Merged
feat: Default dimensions from powertools instead of emf library #317pankajagrawal16 merged 5 commits intomasterfrom
pankajagrawal16 merged 5 commits intomasterfrom
Conversation
pankajagrawal16
force-pushed
the
default-dimensions
branch
from
40eef68 to
83e390b
Compare
since EMF supports no dimension as well
msailes
reviewed
Mar 9, 2021
pankajagrawal16
force-pushed
the
default-dimensions
branch
from
a3420b1 to
f5d30fe
Compare
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Issue #297 #320
Description of changes:
Powertools wont capture default dimesion emitted via emf library. By default, it emits following dimensions
"Dimensions":[["LogGroup","ServiceName","ServiceType","Service"]].Now in sync with python version, it will by default emit only
ServicedimensionChecklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.