chore(v2): document use of aws-crt-client (#1092)#1605
chore(v2): document use of aws-crt-client (#1092)#1605scottgerring merged 14 commits intoaws-powertools:v2from jreijn:chore/v2-document-use-of-crt-client
Conversation
| ``` | ||
|
|
||
| After configuring the dependencies it's required to specify the aws sdk http client. | ||
| Most modules support a custom sdk client by leveraging the `.withClient()` method on the for instance the Provider singleton: |
There was a problem hiding this comment.
something missing here...
There was a problem hiding this comment.
I've tried to clarify it a bit more. I noticed I focussed too much on the parameters module, but other modules also use the url-connection client. Turned it into an example for a module and described that it depends on the PT module in use how to further configure the http client.
Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
|
@jeromevdl thank you for the thorough review! I've incorporated most of your suggestions and tried to be more explicit on the unclear part. |
scottgerring
left a comment
There was a problem hiding this comment.
Nice! Couple of nitpicks inline but looking good. Also immediately helpful for the next time I need to remember how to set this all up :D
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
|
Some great additions @scottgerring ! Thanks so much. I do have one outstanding issue for myself. I mentioned the |
If you use 2.0.0 we should be safe! We've got a rather rough script in the build that goes through and subs this all out when we do releases. I believe we're using 2.0.0 elsewhere in the docs. |
|
scottgerring
left a comment
There was a problem hiding this comment.
LGTM! Cheers @jreijn




Issue #, if available: #1092
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.